Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github url strings (org edx -> openedx) #144

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Conversation

sarina
Copy link

@sarina sarina commented Sep 7, 2022

This PR was autogenerated

This pr replaces the old GitHub organization, github.com/edx, with the new GitHub organization, github.com/openedx.

Tagging @openedx/tcril-engineering for review, but others are welcome to provide review.

Ref: openedx/axim-engineering#42

@@ -39,7 +39,7 @@ jobs:

- name: setup testeng-ci
run: |
git clone https://github.com/edx/testeng-ci.git
git clone https://github.com/openedx/testeng-ci.git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo did not get moved as a part of the transition and still lives in the edx org. We should not update this URL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I'm going to address this after I set up the automation to correctly update pylintrc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct solution is to use the .github/workflow-templates/upgrade-python-requirements.yml file, which I've done now.

@sarina sarina force-pushed the tcril/fix-gh-org-url branch 2 times, most recently from 251369a to 65ca008 Compare September 9, 2022 20:27
@sarina
Copy link
Author

sarina commented Sep 9, 2022

@feanil my script now auto-does edx_lint and I removed the only other occurrence I found of github.com/edx per your review.

edit: i was spacing yesterday afternoon, i can continue my script without this merging - so take your time.

@sarina sarina force-pushed the tcril/fix-gh-org-url branch from 65ca008 to 57c380d Compare September 10, 2022 19:40
@sarina sarina force-pushed the tcril/fix-gh-org-url branch from 58a0141 to 00da98a Compare September 17, 2022 18:09
@feanil feanil self-requested a review September 19, 2022 18:03
@sarina sarina force-pushed the tcril/fix-gh-org-url branch from 00da98a to f67c299 Compare September 19, 2022 20:32
This workflow is defined in the .github repo, under the
workflow-templates directory. It should not be hand-edited.
@sarina sarina force-pushed the tcril/fix-gh-org-url branch from f67c299 to fa705e0 Compare September 19, 2022 20:33
@sarina sarina merged commit 725cdb5 into edx_release Sep 19, 2022
@sarina sarina deleted the tcril/fix-gh-org-url branch September 19, 2022 20:41
@aht007
Copy link
Member

aht007 commented Nov 7, 2022

@sarina I can see that @openedx/arbi-bom was removed from the team-reviewers due to this transition but no other user/team was added for review. This would mean that requirements upgrade PR would go unnoticed. @openedx/2u-aperture can you please put yourself as the reviewing team in the workflow. Thanks

@sarina
Copy link
Author

sarina commented Nov 7, 2022

This is a pull request closed 2 months ago. I am confused why comments are being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants