A11y fixes #23
Merged
A11y fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
force-pushed
the
christina/a11y
branch
from
dc6fa8c to
eb5a02c
Compare
8 tasks
cahrens
commented
Feb 8, 2017
| @@ -22,14 +22,14 @@ | |||
| {% trans "Add article" %} | |||
| </a> | |||
| </div> | |||
| <div class="pull-right"> | |||
| {{ filter_form.query }} | |||
| <div class="pull-right input-prepend"> | |||
There was a problem hiding this comment.
Add ?w=1 to suppress whitespace differences (though note that then you won't see comments or be able to create them).
cahrens
commented
Feb 8, 2017
| {{ filter_form.query }} | ||
| <div class="pull-right input-prepend"> | ||
| {{ filter_form.query.label_tag }} {{ filter_form.query }} | ||
| {% if filter_query %} |
There was a problem hiding this comment.
Previously "(clear)" was appearing to the left of the input field when it displayed.
cahrens
commented
Feb 8, 2017
| </td> | ||
| </tr> | ||
| {% empty%} | ||
| {% if directory %} |
There was a problem hiding this comment.
Only add the table if there are filter results.
|
Looks good to me 👍 |
|
👍 |
cahrens
force-pushed
the
christina/a11y
branch
2 times, most recently
from
dfda08c to
b7313aa
Compare
cptvitamin
suggested changes
Feb 9, 2017
wiki/templates/wiki/dir.html
Outdated
| <td colspan="100"> | ||
| <em>{% trans "There are no articles in this level" %}</em> | ||
| </td> | ||
| <th>{% trans "Title" %}</th> |
There was a problem hiding this comment.
@cahrens can you add scope="col" to each of these <th> elements?
TNL-6440, TNL-6439
cahrens
force-pushed
the
christina/a11y
branch
from
30694d1 to
906d704
Compare
|
@cptvitamin I did add scope="col". Going ahead and merging. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@staubina and @jlajoie Please review this PR as a companion to https://github.com/edx/edx-platform/pull/14486.
FYI @cptvitamin