fix: push docker image workflow #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @feanil, I'm pushing this PR again because I think we need these images for our CI workflows. here: docker-compose-ci.yml. previous PR: #407 |
feanil
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Can we drop the usage of the docker compose in testing instead? I think we should test this in a more standard way, we used these docker files back when we were on jenkins and needed more consistent builds for testing. Now that we have github actions runners I think we can just drop using the dockerfiles from testing instead. I'm good with merging this to unblock testing but we should come back and clean this all up.
feanil
approved these changes
Sep 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
.github/workflows/push-docker-image.ymlworkflow resolving push authorization issues. It also upgrades Docker actions.