Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build and push docker images CI #407

Closed
wants to merge 3 commits into from
Closed

fix: build and push docker images CI #407

wants to merge 3 commits into from

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented May 2, 2024 •
edited
Loading

farhan
farhan requested changes May 6, 2024
View reviewed changes
.github/workflows/push-docker-image.yml
- name: Build and push Prod Docker image
Copy link
Contributor

@farhan farhan May 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil
Prod images were commented in this PR
Do you have information why did we do that?
Seems ok to me to uncomment it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not pushing the images, then we don't need this workflow at all. Let's just remove it, it was 2U specific anyway.

@irtazaakram irtazaakram mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil left review comments

@farhan farhan farhan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and Push Docker Images CI failing
3 participants
@irtazaakram @feanil @farhan