Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert dates new icons #2248

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Nov 6, 2024

What Changed?

  • Removes the "New" icons from schedule config, now that the feature is no longer truly "new".
  • Updates a bunch of out-of-date packages, in particular @edx/frontend-build which was relying on a no-longer-available version of eslint. This also updates webpack to v5 in the process (Reverted)

JIRA: AU-1433

Before

Screenshot 2024-11-06 at 15 59 49

After

Screenshot 2024-11-06 at 16 00 03

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@KristinAoki
Copy link
Member

LGTM pending the fixing of tests

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (979d3f2) to head (4756243).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2248   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21624    21624           
  Branches     1502     1502           
=======================================
  Hits        20606    20606           
  Misses        771      771           
  Partials      247      247           
Flag Coverage Δ
unittests 95.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsprenkle nsprenkle force-pushed the nsprenkle/revert-dates-new-icons branch from e56583e to c38b0e1 Compare November 13, 2024 23:02
@nsprenkle nsprenkle merged commit b373959 into master Nov 13, 2024
11 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/revert-dates-new-icons branch November 13, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants