feat: upgrading django-oauth-toolkit==1.5.0

[awais786]

https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md#150-2021-03-18

https://github.com/jazzband/django-oauth-toolkit/blob/1.5.0/oauth2_provider/migrations/0004_auto_20200902_2022.py

models.py this file contains the model related changes.

RAW SQL

-- Add field algorithm to application
--
ALTER TABLE `oauth2_provider_application` ADD COLUMN `algorithm` varchar(5) DEFAULT '' NOT NULL;
ALTER TABLE `oauth2_provider_application` ALTER COLUMN `algorithm` DROP DEFAULT;
--
-- Alter field authorization_grant_type on application
--
--
-- Create model IDToken
--
CREATE TABLE `oauth2_provider_idtoken` (`id` bigint AUTO_INCREMENT NOT NULL PRIMARY KEY, `jti` char(32) NOT NULL UNIQUE, `expires` datetime(6) NOT NULL, `scope` longtext NOT NULL, `created` datetime(6) NOT NULL, `updated` datetime(6) NOT NULL, `application_id` bigint NULL, `user_id` integer NULL);
--
-- Add field id_token to accesstoken
--
ALTER TABLE `oauth2_provider_accesstoken` ADD COLUMN `id_token_id` bigint NULL UNIQUE , ADD CONSTRAINT `oauth2_provider_acce_id_token_id_85db651b_fk_oauth2_pr` FOREIGN KEY (`id_token_id`) REFERENCES `oauth2_provider_idtoken`(`id`);
--
-- Add field nonce to grant
--
ALTER TABLE `oauth2_provider_grant` ADD COLUMN `nonce` varchar(255) DEFAULT '' NOT NULL;
ALTER TABLE `oauth2_provider_grant` ALTER COLUMN `nonce` DROP DEFAULT;
--
-- Add field claims to grant
--
ALTER TABLE `oauth2_provider_grant` ADD COLUMN `claims` longtext DEFAULT ('') NOT NULL;
ALTER TABLE `oauth2_provider_idtoken` ADD CONSTRAINT `oauth2_provider_idto_application_id_08c5ff4f_fk_oauth2_pr` FOREIGN KEY (`application_id`) REFERENCES `oauth2_provider_application` (`id`);
ALTER TABLE `oauth2_provider_idtoken` ADD CONSTRAINT `oauth2_provider_idtoken_user_id_dd512b59_fk_auth_user_id` FOREIGN KEY (`user_id`) REFERENCES `auth_user` (`id`);

[awais786]

select count(*) from oauth2_provider_application;
+----------+
| count(*) |
+----------+
|      740 |
+----------+
1 row in set (0.00 sec)

[awais786]

mysql> select count(*) from oauth2_provider_accesstoken;
+----------+
| count(*) |
+----------+
| 20552959 |
+----------+
1 row in set (19.20 sec)

twenty million five hundred fifty-two thousand nine hundred fifty-nine

[awais786]

select count(*) from oauth2_provider_grant;
+----------+
| count(*) |
+----------+
|    25264 |
+----------+
1 row in set (0.10 sec)

[awais786]

mysql> select count(*) from oauth2_provider_accesstoken;
+----------+
| count(*) |
+----------+
| 20552959 |
+----------+
1 row in set (19.20 sec)

twenty million five hundred fifty-two thousand nine hundred fifty-nine

@robrap need your guidance in this migration. Thanks

[awais786]

NOTE: check prod/stage for this upgrde, table size is huge.

[robrap]

Hello @awais786. @rgraber is both on-call and our eSRE. I know of these issues in general, but typically I'd go to SRE. Maybe @rgraber can either support you or help work with SRE on this to learn best practices.

[awais786]

@rgraber may be it can be run on clone first and see if there is any issue ?

[rgraber]

@rgraber may be it can be run on clone first and see if there is any issue ?

I think I can do this. I'm consulting with SRE now.

[rgraber]

From Nadeem:

The only concerned query is where we are adding nullable Columba for a large table which contain 20 million rows
ALTER TABLE oauth2_provider_accesstoken ADD COLUMN id_token_id bigint NULL UNIQUE ,
Specifically, the statement in the AWS documentation mentions that Fast DDL only supports adding nullable columns to the end of an existing table. Our query is adding a nullable column (id_token_id) to the existing table oauth2_provider_accesstoken, which aligns with this statement.
However, it is also specifying UNIQUE on the new column. We are using feature Fast DDL but the addition of the UNIQUE constraint might still can take time on large table.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.