Skip to content

Commit

Permalink
chore: quality fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Ian2012 committed Mar 1, 2024
1 parent c6ec7c6 commit 3a8032c
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 8 deletions.
1 change: 1 addition & 0 deletions event_routing_backends/backends/events_router.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import json
import logging
from datetime import datetime, timedelta

from django.conf import settings
from django_redis import get_redis_connection
from eventtracking.processors.exceptions import EventEmissionExit
Expand Down
2 changes: 1 addition & 1 deletion event_routing_backends/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def get_user(username_or_id):
if username and not user:
try:
user = get_potentially_retired_user_by_username(username)
except Exception as ex:
except Exception as ex: # pylint: disable=broad-except
logger.info('User with username "%s" does not exist.%s', username, ex)

return user
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _get_chunks(source, file, start_byte, end_byte):
break
# Catching all exceptions here because there's no telling what all
# the possible errors from different libcloud providers are.
except Exception as e:
except Exception as e: # pylint: disable=broad-except
print(e)
if try_number == num_retries:
print(f"Try {try_number}: Error occurred downloading, giving up.")
Expand Down
3 changes: 0 additions & 3 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,4 @@ import-graph =
ext-import-graph =
int-import-graph =

[EXCEPTIONS]
overgeneral-exceptions = builtins.Exception

# 056eb70bf90e13f94ca9ae8ac1fa84836c7139ba
3 changes: 0 additions & 3 deletions pylintrc_tweaks
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ load-plugins = edx_lint.pylint,pylint_django,pylint_celery
[MESSAGES CONTROL]
disable+=
logging-format-interpolation,

[EXCEPTIONS]
overgeneral-exceptions = builtins.Exception

0 comments on commit 3a8032c

Please sign in to comment.