Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #1152

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

OmarIthawi
Copy link
Member

Similar to openedx/frontend-app-communications#187.

Changes

  • install atlas
  • remove --filter to pull all languages by default
  • use ATLAS_OPTIONS to allow custom --filter
  • include frontend-platform in atlas pull

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@OmarIthawi OmarIthawi requested a review from a team as a code owner January 29, 2024 14:24
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

 - install atlas
 - remove `--filter` to pull all languages by default
 - use ATLAS_OPTIONS to allow custom `--filter`
 - include frontend-platform in `atlas pull`
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8be4696) 87.52% compared to head (cf372fe) 87.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         124      124           
  Lines        2253     2253           
  Branches      628      628           
=======================================
  Hits         1972     1972           
  Misses        272      272           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril
Copy link
Contributor

@zainab-amir you are listed as "Review required from" for this repo on the spreadsheet. The sooner you can review and merge this the better. Thank you!

@OmarIthawi OmarIthawi changed the title feat: tutor-mfe compatiblilty for atlas pull feat: tutor-mfe compatiblilty for atlas pull | FC-0012 Jan 29, 2024
@brian-smith-tcril
Copy link
Contributor

@zainab-amir I plan on merging this in the next half hour or so, please let me know if I should hold off.

@brian-smith-tcril brian-smith-tcril merged commit a6a473e into openedx:master Jan 30, 2024
7 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants