-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #1152
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
- install atlas - remove `--filter` to pull all languages by default - use ATLAS_OPTIONS to allow custom `--filter` - include frontend-platform in `atlas pull`
6562c92
to
cf372fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 124 124
Lines 2253 2253
Branches 628 628
=======================================
Hits 1972 1972
Misses 272 272
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@zainab-amir you are listed as "Review required from" for this repo on the spreadsheet. The sooner you can review and merge this the better. Thank you! |
@zainab-amir I plan on merging this in the next half hour or so, please let me know if I should hold off. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Similar to openedx/frontend-app-communications#187.
Changes
--filter
to pull all languages by default--filter
atlas pull
Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.