Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed logistration page placeholder issue #1423

Closed
wants to merge 3 commits into from

Conversation

sundasnoreen12
Copy link
Contributor

Description

The overlapping issue of the email and password input fields are fixed now.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 requested a review from a team as a code owner February 18, 2025 08:44
@sundasnoreen12 sundasnoreen12 force-pushed the sundas/INF-1786 branch 2 times, most recently from 81d24ed to e1dfa30 Compare February 18, 2025 09:07
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (5d481a9) to head (ffe306b).

Files with missing lines Patch % Lines
src/common-components/data/service.js 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   87.69%   87.42%   -0.27%     
==========================================
  Files         124      125       +1     
  Lines        2299     2338      +39     
  Branches      646      655       +9     
==========================================
+ Hits         2016     2044      +28     
- Misses        274      284      +10     
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants