Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented restricted country implementation #1425

Open
wants to merge 4 commits into
base: 2u-main
Choose a base branch
from

Conversation

sundasnoreen12
Copy link
Contributor

Description

We are introducing a feature that allows platform administrators to restrict users from selecting one or more countries in Authn MFE.

How Has This Been Tested?

We retrieved the list of restricted countries by calling the following API:

👉 https://courses.edx.org/user_api/v1/account/registration/

At the same time, we obtained the translated country names using the i18n-iso-countries package.

Once both datasets were available, we filtered out the restricted countries from the translated list and displayed the updated country list in the UI.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 requested a review from a team as a code owner February 20, 2025 11:06
@sundasnoreen12 sundasnoreen12 changed the base branch from master to 2u-main February 20, 2025 11:07
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.07%. Comparing base (1477ed3) to head (1ab1558).
Report is 59 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/common-components/data/service.js 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1425      +/-   ##
===========================================
- Coverage    86.57%   86.07%   -0.50%     
===========================================
  Files          134      139       +5     
  Lines         2413     2471      +58     
  Branches       669      678       +9     
===========================================
+ Hits          2089     2127      +38     
- Misses         311      328      +17     
- Partials        13       16       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari changed the title Sundas new/inf 1779 feat: implemented restricted country implementation Feb 20, 2025
@awais-ansari
Copy link

Please improve test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants