generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented restricted country implementation #1425
Open
sundasnoreen12
wants to merge
4
commits into
2u-main
Choose a base branch
from
sundas-new/INF-1779
base: 2u-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2u-main #1425 +/- ##
===========================================
- Coverage 86.57% 86.07% -0.50%
===========================================
Files 134 139 +5
Lines 2413 2471 +58
Branches 669 678 +9
===========================================
+ Hits 2089 2127 +38
- Misses 311 328 +17
- Partials 13 16 +3 ☔ View full report in Codecov by Sentry. |
ayesha-waris
approved these changes
Feb 20, 2025
awais-ansari
requested changes
Feb 20, 2025
Please improve test coverage. |
awais-ansari
requested changes
Feb 21, 2025
awais-ansari
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are introducing a feature that allows platform administrators to restrict users from selecting one or more countries in Authn MFE.
How Has This Been Tested?
We retrieved the list of restricted countries by calling the following API:
👉 https://courses.edx.org/user_api/v1/account/registration/
At the same time, we obtained the translated country names using the i18n-iso-countries package.
Once both datasets were available, we filtered out the restricted countries from the translated list and displayed the updated country list in the UI.
Merge Checklist
Post-merge Checklist