-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cast progress graph configuration to string #495
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 74.70% 74.70%
=======================================
Files 109 109
Lines 2107 2107
Branches 519 519
=======================================
Hits 1574 1574
Misses 505 505
Partials 28 28
☔ View full report in Codecov by Sentry. |
Hi @openedx/teaching-and-learning! Would someone be able to approve/merge this? |
@jristau1984: thanks for the review! I don't have permissions to merge. Can you give us a hand? Thanks again! |
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
(cherry picked from commit 51e5e71)
Description
These changes cast the
ENABLE_PROGRESS_GRAPH_SETTINGS
before comparison. This PR solves: openedx/wg-build-test-release#278 reported while testing the Palm release.This was the error raised in a local environment:
Now, after using this change:
How to test
Using tutor:
tutor local start