Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect redirection link to Pages&Resources from Custom Pages to Quince #915

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Mar 22, 2024

This is a backport from the master branch.

Description

If you have organized routing on your server using the <app.domain.com>/<name-mfe>/... method, then an error will occur for redirection for this link (this part is lost <name-mfe>):

screen_45

You will not be able to reproduce this error on a local instance:

screen_44 screen_43

The solution involves more flexible routing

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@9192287). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #915   +/-   ##
=============================================================
  Coverage                              ?   86.81%           
=============================================================
  Files                                 ?      378           
  Lines                                 ?     5705           
  Branches                              ?     1260           
=============================================================
  Hits                                  ?     4953           
  Misses                                ?      730           
  Partials                              ?       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov DmytroAlipov changed the title fix: incorrect redirect link to Pages&Resources from Custom Pages fix: incorrect redirection link to Pages&Resources from Custom Pages to Quince Mar 22, 2024
@DmytroAlipov DmytroAlipov added the backport PR backports a change from main to a named release. label Mar 22, 2024
@mphilbrick211 mphilbrick211 requested a review from a team March 22, 2024 19:03
@DmytroAlipov
Copy link
Contributor Author

Hi @mphilbrick211
Is it possible to have someone review this MR so that this fix can be included in Quince 3?

@KristinAoki KristinAoki merged commit 4592c0d into openedx:open-release/quince.master Apr 8, 2024
6 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the incorrect-redirection-link-quince branch April 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants