feat: use `atlas` in `make pull_translations` #502

OmarIthawi · 2023-04-24T11:56:18Z

Changes

Move all i18n imports into src/i18n/index.js so intl-imports.js can override it with latest translations
Add atlas into make pull_translations when OPENEDX_ATLAS_PULL environment variable is set.

Testing

Fix tests and lint rules
Test pulled translations
Quick QA for translated content:

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

Remove source and language translations from the repositories, hence no .json, .po or .mo files will be committed into the repos.
Add standardized make extract_translations in all repositories
Push user-facing messages strings into openedx/openedx-translations.
Integrate root repositories with openedx/openedx-atlas to pull translations on build/deploy time

Breaking Changes

One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:

For Micro-frontends:

Legacy hardcoded translations are kept into the repo.
Consolidate all i18n imports into src/i18n/index.js
Add atlas integration in make pull_translations but only if OPENEDX_ATLAS_PULL is set
Bump frontend-platform and use intl-imports.js to generate up to date import files
If translations is missing, they're added according to the latest Micro-frontend i18n pattern in par with https://github.com/openedx/frontend-template-application/

openedx-webhooks · 2023-04-24T11:56:23Z

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2023-04-24T12:24:34Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2b33b7) 91.88% compared to head (2c186d1) 91.88%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         170      170           
  Lines        3474     3474           
  Branches      905      905           
=======================================
  Hits         3192     3192           
  Misses        263      263           
  Partials       19       19

Impacted Files	Coverage Δ
src/index.jsx	`0.00% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

brian-smith-tcril

This looks great! One tiny comment then this should be good to go!

package.json

e0d · 2023-04-27T19:42:29Z

@OmarIthawi looks like a conflict was introduced, can you have a look?

OmarIthawi · 2023-05-01T05:29:47Z

@e0d the conflicts seems to be resolve for other reasons.

brian-smith-tcril · 2023-05-02T14:58:28Z

@jristau1984 @asadazam93 the spreadsheet says to inform you before merging this. It's ready to go, any reason I should hold off?

brian-smith-tcril · 2023-05-08T15:03:49Z

@OmarIthawi looks like this has a conflict again

OmarIthawi · 2023-05-09T08:35:05Z

@brian-smith-tcril done. cc: @jristau1984 @asadazam93

brian-smith-tcril · 2023-05-09T14:10:05Z

@OmarIthawi looks like tests are failing on this one now

OmarIthawi · 2023-05-09T16:59:13Z

Those in principle, shouldn't fail. But I'm looking into them anyway.

asadazam93 · 2023-05-11T15:01:05Z

@OmarIthawi we have another PR that upgrades the frontend platform version. I think it would make sense to merge that one first.

OmarIthawi · 2023-05-11T15:13:00Z

@asadazam93 yes please, I'd love it if that happens soon :)

brian-smith-tcril · 2023-05-18T20:11:45Z

I'm marking this as "blocked by other work" until #518 is resolved. I'll revisit next week and if the failing tests on master are still not resolved I'll consider merging it with failing tests.

awais-ansari

@OmarIthawi Is this PR ready for merge?

OmarIthawi · 2023-05-24T12:07:39Z

Yes, it's ready for merge @awais-ansari. Thanks for checking.

awais-ansari

@OmarIthawi "@edx/frontend-platform": "4.2.0" required node 18 version and node upgrade is in progress now. For now. I’m blocking this PR on node 18 upgrade PR.

awais-ansari

@OmarIthawi node 18 upgrades is done. Please rebase is PR with master and resolve the conflicts.

Changes ------- - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.

openedx-webhooks · 2023-05-25T13:38:33Z

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Changes ------- - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 24, 2023

OmarIthawi force-pushed the atlas branch 2 times, most recently from e4a6e1a to dd8cec9 Compare April 24, 2023 12:13

OmarIthawi marked this pull request as draft April 24, 2023 12:23

OmarIthawi marked this pull request as ready for review April 25, 2023 08:59

brian-smith-tcril reviewed Apr 25, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

OmarIthawi requested a review from brian-smith-tcril April 27, 2023 08:06

brian-smith-tcril approved these changes Apr 27, 2023

View reviewed changes

OmarIthawi force-pushed the atlas branch from dd8cec9 to f4afb57 Compare May 1, 2023 05:29

brian-smith-tcril added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 8, 2023

OmarIthawi force-pushed the atlas branch 2 times, most recently from 7f20148 to 716e03d Compare May 9, 2023 08:31

OmarIthawi force-pushed the atlas branch 2 times, most recently from 8d0de36 to 277a72c Compare May 9, 2023 16:56

OmarIthawi force-pushed the atlas branch 3 times, most recently from 889b1b6 to 7a1a8d6 Compare May 11, 2023 14:59

OmarIthawi mentioned this pull request May 11, 2023

build: edx namespace packages upgrade & resolved respective eslint issue #508

Merged

4 tasks

OmarIthawi force-pushed the atlas branch from 7a1a8d6 to dc26813 Compare May 16, 2023 12:41

OmarIthawi force-pushed the atlas branch from dc26813 to 06bd7d0 Compare May 16, 2023 15:19

brian-smith-tcril added the blocked by other work PR cannot be finished until other work is complete label May 18, 2023

OmarIthawi force-pushed the atlas branch from 06bd7d0 to 6965dc1 Compare May 24, 2023 10:09

awais-ansari reviewed May 24, 2023

View reviewed changes

OmarIthawi requested a review from awais-ansari May 24, 2023 12:08

awais-ansari reviewed May 24, 2023

View reviewed changes

awais-ansari removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 24, 2023

awais-ansari reviewed May 25, 2023

View reviewed changes

awais-ansari added engineering review and removed blocked by other work PR cannot be finished until other work is complete labels May 25, 2023

OmarIthawi force-pushed the atlas branch from 6965dc1 to 2c186d1 Compare May 25, 2023 13:26

OmarIthawi requested a review from awais-ansari May 25, 2023 13:26

awais-ansari approved these changes May 25, 2023

View reviewed changes

awais-ansari merged commit 733a74d into openedx:master May 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use `atlas` in `make pull_translations` #502

feat: use `atlas` in `make pull_translations` #502

OmarIthawi commented Apr 24, 2023 •

edited

Loading

openedx-webhooks commented Apr 24, 2023 •

edited

Loading

codecov bot commented Apr 24, 2023 •

edited

Loading

brian-smith-tcril left a comment

e0d commented Apr 27, 2023

OmarIthawi commented May 1, 2023

brian-smith-tcril commented May 2, 2023

brian-smith-tcril commented May 8, 2023

OmarIthawi commented May 9, 2023

brian-smith-tcril commented May 9, 2023

OmarIthawi commented May 9, 2023

asadazam93 commented May 11, 2023

OmarIthawi commented May 11, 2023

brian-smith-tcril commented May 18, 2023

awais-ansari left a comment

OmarIthawi commented May 24, 2023

awais-ansari left a comment

awais-ansari left a comment

openedx-webhooks commented May 25, 2023

feat: use atlas in make pull_translations #502

feat: use atlas in make pull_translations #502

Conversation

OmarIthawi commented Apr 24, 2023 • edited Loading

Changes

Testing

References

Breaking Changes

openedx-webhooks commented Apr 24, 2023 • edited Loading

codecov bot commented Apr 24, 2023 • edited Loading

Codecov Report

brian-smith-tcril left a comment

Choose a reason for hiding this comment

e0d commented Apr 27, 2023

OmarIthawi commented May 1, 2023

brian-smith-tcril commented May 2, 2023

brian-smith-tcril commented May 8, 2023

OmarIthawi commented May 9, 2023

brian-smith-tcril commented May 9, 2023

OmarIthawi commented May 9, 2023

asadazam93 commented May 11, 2023

OmarIthawi commented May 11, 2023

brian-smith-tcril commented May 18, 2023

awais-ansari left a comment

Choose a reason for hiding this comment

OmarIthawi commented May 24, 2023

awais-ansari left a comment

Choose a reason for hiding this comment

awais-ansari left a comment

Choose a reason for hiding this comment

openedx-webhooks commented May 25, 2023

feat: use `atlas` in `make pull_translations` #502

feat: use `atlas` in `make pull_translations` #502

OmarIthawi commented Apr 24, 2023 •

edited

Loading

openedx-webhooks commented Apr 24, 2023 •

edited

Loading

codecov bot commented Apr 24, 2023 •

edited

Loading