Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update paragon and frontend-build to openedx #285

Closed

Conversation

Yagnesh1998
Copy link

@Yagnesh1998 Yagnesh1998 commented Feb 7, 2024

There is an edx organization on NPM that currently publishes many packages. An organization can't be renamed but there is a process for moving packages between organizations. The edx organization or scope as NPM calls it, has both packages that are a part of the Open edX ecosystem as well as packages that are specific to edx.org. To reduce confusion we'll be moving the openedx packages to a new openedx scope in NPM.

Impact
Any downstream packages that depend on a package that has moved will need to update its dependencies and imports to pull the same files from the new package location and version.

@openedx-webhooks
Copy link

Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
@brian-smith-tcril
Copy link
Contributor

Thank you so much for doing this @Yagnesh1998!

I tried pulling this locally and running

nvm use
npm ci

and it failed. I then deleted the package-lock.json file and ran npm install and was able to run the MFE.

I then ran npm test and all but 1 test passed. It seems that was just a find/replace error here https://github.com/openedx/frontend-app-learner-dashboard/pull/285/files#r1481954243

If you:

  • apply my linked suggestion
  • rebase this PR on latest master
  • delete/regenerate the package-lock.json

then this should be good to move out of draft!

@Yagnesh1998 Yagnesh1998 closed this Feb 7, 2024
@Yagnesh1998 Yagnesh1998 force-pushed the yagnesh-openedx-namespaced branch from f4c7463 to ad56b36 Compare February 7, 2024 20:47
@openedx-webhooks
Copy link

@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Yagnesh1998 Yagnesh1998 deleted the yagnesh-openedx-namespaced branch February 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants