feat: fix styling

openedx · Mar 24, 2021 · 76eb9a8 · 76eb9a8
1 parent 296b1e2
commit 76eb9a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/course-search/TypeaheadFacetDropdown.jsx b/src/course-search/TypeaheadFacetDropdown.jsx
@@ -21,7 +21,7 @@ const TypeaheadFacetDropdown = ({
 
   const transformMenuOptions = menuOptions => (
     <>
-      <div className="p-2">
+      <div className="pr-2 pl-2 pb-2">
         <Input
           autoFocus
           type="search"

diff --git a/src/course-search/styles/_FacetList.scss b/src/course-search/styles/_FacetList.scss
@@ -32,6 +32,7 @@ $facet-dropdown-max-height: 250px;
   .typeahead {
     .dropdown-menu {
       max-height: unset;
+      overflow-y: unset;
 
       .typeahead-dropdown-menu-scrollable-items {
         max-height: $facet-dropdown-max-height;

diff --git a/src/course-search/tests/FacetListBase.test.jsx b/src/course-search/tests/FacetListBase.test.jsx
@@ -45,7 +45,11 @@ const searchableDropdownProps = {
   searchForItems: jest.fn(),
   searchable: true,
   isBold: true,
-  typeaheadOptions: { placeholder: 'Find a skill', ariaLabel: 'Type to find a skill', minLength: 3 },
+  typeaheadOptions: {
+    placeholder: 'Find a skill...',
+    ariaLabel: 'Type to find a skill',
+    minLength: 3,
+  },
 };
 
 describe('<FacetListBase />', () => {