Enable support for React 18 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/react-18
branch
from
b9a1fce to
583f7db
Compare
adamstankiewicz
force-pushed
the
ags/react-18
branch
from
69993e6 to
e8b5003
Compare
|
closing and re-opening to get actions to run |
adamstankiewicz
force-pushed
the
ags/react-18
branch
2 times, most recently
from
b65cc91 to
5c37a29
Compare
adamstankiewicz
force-pushed
the
ags/react-18
branch
from
6054fa9 to
0b320a4
Compare
adamstankiewicz
commented
Feb 24, 2025
| }, | ||
| "peerDependencies": { | ||
| "@edx/frontend-component-footer": "*", | ||
| "react": "^17.0.0" | ||
| "react": "^17.0.0 || ^18.0.0", | ||
| "react-dom": "^17.0.0 || ^18.0.0" |
There was a problem hiding this comment.
[inform] Any concerns about including react-dom here? My understand is that anywhere react is a peer dep, react-dom should be, too?
There was a problem hiding this comment.
I think adding react-dom here makes sense. It's a peer dep in frontend-component-footer so that's likely why not having it wasn't causing problems before.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Open edX MFEs are overdue to support React 18 (especially as React 19 is already out now, too). Some efforts have been started to support React 18 in the shared JavaScript libraries, such as Paragon (openedx/paragon#3367, v22 and v23).
By enabling support for React 18 (should be additive-only), we can further enable incremental migration to React 18 within MFEs. Most of the changes are within the example MFE included in this repository for testing.
The React 18 Upgrade Guide was followed.