Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/#450 metadata etrago tables #1117

Merged
merged 18 commits into from
Mar 15, 2023
Merged

Features/#450 metadata etrago tables #1117

merged 18 commits into from
Mar 15, 2023

Conversation

ClaraBuettner
Copy link
Contributor

@AmeliaNadal I added some metadata for the etrago tables on this branch.

AmeliaNadal
AmeliaNadal reviewed Mar 13, 2023
View reviewed changes
src/egon/data/datasets/etrago_setup.py
@@ -129,8 +129,35 @@ def __init__(self, dependencies):


class EgonPfHvBus(Base):

source_list = [
sources()["egon-data"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we really cite this eGon-data as a source in our metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added it like this to every table, so I think it's fine.

@KathiEsterl
Copy link
Contributor

Sources used in PV_ground_mounted -> power plants table -> etrago generators:

mastr (existierende Einheiten)
potential areas (RLI)
vg250 (Bundesland-shapes)
nep (Kapazitäten-Zielwerte pro Bundesland)

@ClaraBuettner
Copy link
Contributor Author

I'm done with the meta data for all etrago tables.
Does someone wants to check it before I merge it into the other 450-branch?
I did not checked every metadata json with the OMI-tool, but at least some of them.

@ClaraBuettner
Copy link
Contributor Author

Sources used in PV_ground_mounted -> power plants table -> etrago generators:

mastr (existierende Einheiten) potential areas (RLI) vg250 (Bundesland-shapes) nep (Kapazitäten-Zielwerte pro Bundesland)

I added all sources except the potential areas since I didn't know how to cite them.
Is it fine to add them later, as soon as these tables have meta data?

@ClaraBuettner ClaraBuettner merged commit 9dee3d0 into features/#450-add-metadata Mar 15, 2023
@ClaraBuettner ClaraBuettner deleted the features/#450-metadata-etrago-tables branch August 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KathiEsterl KathiEsterl KathiEsterl left review comments

@AmeliaNadal AmeliaNadal AmeliaNadal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClaraBuettner @KathiEsterl @AmeliaNadal