PR Grumbles

js/src/modals/CreateAccount/NewAccount/newAccount.js

@@ -19,7 +19,7 @@ import { IconButton } from 'material-ui';
 import { RadioButton, RadioButtonGroup } from 'material-ui/RadioButton';
 import ActionAutorenew from 'material-ui/svg-icons/action/autorenew';
 
-import { Form, Input, IdentityIcon, PasswordStrength } from '~/ui';
+import { Form, Input, IdentityIcon } from '~/ui';
 
 import ERRORS from '../errors';
 
@@ -90,7 +90,6 @@ export default class CreateAccount extends Component {
               onChange={ this.onEditPassword2 } />
           </div>
         </div>
-        <PasswordStrength input={ password1 } />
         { this.renderIdentitySelector() }
         { this.renderIdentities() }
       </Form>

js/src/modals/CreateAccount/RawKey/rawKey.js

@@ -16,7 +16,7 @@
 
 import React, { Component, PropTypes } from 'react';
 
-import { Form, Input, PasswordStrength } from '~/ui';
+import { Form, Input } from '~/ui';
 
 import styles from '../createAccount.css';
 
@@ -92,7 +92,6 @@ export default class RawKey extends Component {
               onChange={ this.onEditPassword2 } />
           </div>
         </div>
-        <PasswordStrength input={ password1 } />
       </Form>
     );
   }

js/src/modals/CreateAccount/RecoveryPhrase/recoveryPhrase.js

@@ -17,7 +17,7 @@
 import React, { Component, PropTypes } from 'react';
 import { Checkbox } from 'material-ui';
 
-import { Form, Input, PasswordStrength } from '~/ui';
+import { Form, Input } from '~/ui';
 
 import styles from '../createAccount.css';
 
@@ -89,7 +89,6 @@ export default class RecoveryPhrase extends Component {
               onChange={ this.onEditPassword2 } />
           </div>
         </div>
-        <PasswordStrength input={ password1 } />
         <Checkbox
           className={ styles.checkbox }
           label='Key was created with Parity <1.4.5 on Windows'

js/src/ui/Form/PasswordStrength/passwordStrength.js

@@ -29,7 +29,6 @@ const BAR_STYLE = {
 };
 
 export default class PasswordStrength extends Component {
-
   static propTypes = {
     input: PropTypes.string.isRequired
   };
@@ -41,7 +40,7 @@ export default class PasswordStrength extends Component {
   constructor (props) {
     super(props);
 
-    this.updateStrength = debounce(this._updateStrength, 500, { leading: true });
+    this.updateStrength = debounce(this._updateStrength, 50, { leading: true });
   }
 
   componentWillMount () {
@@ -76,7 +75,7 @@ export default class PasswordStrength extends Component {
       <div className={ styles.strength }>
         <label className={ styles.label }>
           <FormattedMessage
-            id='passwordStrength.label'
+            id='ui.passwordStrength.label'
             defaultMessage='password strength'
           />
         </label>
@@ -96,14 +95,12 @@ export default class PasswordStrength extends Component {
   // Note that the suggestions are in english, thus it wouldn't
   // make sense to add translations to surrounding words
   renderFeedback (feedback = {}) {
-    const { crack_times_display } = this.state.strength;
     const { suggestions = [] } = feedback;
 
     return (
       <div>
         <p>
-          It would take { crack_times_display.offline_slow_hashing_1e4_per_second } to crack this password.
-          &nbsp;{ suggestions.join(' ') }
+          { suggestions.join(' ') }
         </p>
       </div>
     );
@@ -122,7 +119,6 @@ export default class PasswordStrength extends Component {
         return 'orange';
 
       default:
-      case 0:
         return 'red';
     }
   }

js/src/ui/Form/PasswordStrength/passwordStrength.spec.js

@@ -33,6 +33,9 @@ describe('ui/Form/PasswordStrength', () => {
   describe('rendering', () => {
     it('renders', () => {
       expect(render({ input: INPUT_A })).to.be.ok;
+    });
+
+    it('renders a linear progress', () => {
       expect(render({ input: INPUT_A }).find('LinearProgress')).to.be.ok;
     });