Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Lookup for keystore in a testnet dir #1089

Closed
sammy007 opened this issue May 16, 2016 · 3 comments
Closed

Lookup for keystore in a testnet dir #1089

sammy007 opened this issue May 16, 2016 · 3 comments
Assignees
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.

Comments

@sammy007
Copy link

I believe parity should look for accounts in ~/Library/Ethereum/testnet/keystore if --testnet used.

@NikVolf NikVolf added the P7-nicetohave 🐕 Issue is worth doing eventually. label May 17, 2016
@NikVolf NikVolf self-assigned this May 17, 2016
@gavofyork
Copy link
Contributor

gavofyork commented May 17, 2016

@NikVolf this is more short-sighted geth-compatibility than core client stuff.

for this to work nicely, we need to separate the keystore path (e.g. --keys-path) from the main DB path, then as a geth-compatibility thing, make --testnet mean two things; --chain morden (it means this already) and --keys-path $ETHEREUM/testnet/keystore (where $ETHEREUM = $HOME/.ethereum on linux and $HOME/Library/Ethereum on Mac).

@gavofyork gavofyork added the F8-enhancement 🎊 An additional feature request. label May 17, 2016
@jorisbontje
Copy link

Running parity --chain morden --keys-path ~/Library/Ethereum/testnet/keystore causes parity to dump my mainnet geth keys into the testnet keystore; while ignoring my testnet keys. So that doesn't work as viable workaround.

@gavofyork
Copy link
Contributor

gavofyork commented May 20, 2016

indeed - also need to avoid parity importing anything when a non-standard keys-path is provided. #1112

@gavofyork gavofyork assigned gavofyork and unassigned NikVolf May 21, 2016
gavofyork added a commit that referenced this issue May 21, 2016
- Now a `--no-import-keys` option;
- `--testnet` now alters the import location for keys and the store path.

Fixes #1112 and #1089.
gavofyork added a commit that referenced this issue May 21, 2016
* Avoid importing keys into wrong place.

- Now a `--no-import-keys` option;
- `--testnet` now alters the import location for keys and the store path.

Fixes #1112 and #1089.

* Avoid double-bools.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

4 participants