Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

eth_gasPrice typically too low #1265

Closed
gavofyork opened this issue Jun 13, 2016 · 2 comments
Closed

eth_gasPrice typically too low #1265

gavofyork opened this issue Jun 13, 2016 · 2 comments
Assignees
@gavofyork
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue.
Milestone
1.2 Security

Comments

@gavofyork
Copy link
Contributor

gavofyork commented Jun 13, 2016 •
edited
Loading

eth_gasPrice should return median price from last 100 blocks
@gavofyork gavofyork added the F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. label Jun 13, 2016
@gavofyork gavofyork added this to the 1.2 Security milestone Jun 13, 2016
@gavofyork gavofyork changed the title Transaction sending should work reliably eth_gasPrice should return median price from last 100 blocks Jun 14, 2016
@gavofyork gavofyork changed the title eth_gasPrice should return median price from last 100 blocks eth_gasPrice typically too low Jun 14, 2016
@gavofyork gavofyork self-assigned this Jun 14, 2016
@debris
Copy link
Collaborator

debris commented Jun 14, 2016

can we also calculate other things? eg. average block time of 100 blocks. I've talked to @goldylucks and it may be useful for him

@gavofyork gavofyork mentioned this issue Jun 14, 2016
Closed
gavofyork added a commit that referenced this issue Jun 14, 2016
@gavofyork
Gas price statistics.
bae08c4 
Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265
@gavofyork gavofyork mentioned this issue Jun 14, 2016
Merged
@gavofyork
Copy link
Contributor Author

i can tell you now: the average block time of last 100 blocks is approximately 15s/block.

gavofyork added a commit that referenced this issue Jun 16, 2016
@gavofyork
Gas price statistics. (#1291)
88b0358 
* Gas price statistics.

Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265

* Fix a bug in eth_gasPrice

* Fix tests.

* Revert minor alteration.

* Tests for gas_price_statistics.

- Tests;
- Additional infrastructure for generating test blocks with
transactions.
arkpar pushed a commit that referenced this issue Jun 18, 2016
@gavofyork @arkpar
Gas price statistics. (#1291)
335bce8 
* Gas price statistics.

Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265

* Fix a bug in eth_gasPrice

* Fix tests.

* Revert minor alteration.

* Tests for gas_price_statistics.

- Tests;
- Additional infrastructure for generating test blocks with
transactions.
gavofyork pushed a commit that referenced this issue Jun 18, 2016
@tomusdrw @gavofyork
Disabling ethcore_set* APIs by default (+ Status page update) (#1315)
e957565 
* More meaningful errors when sending transaction

* Fixing returned value

* Consolidating all RPC error codes

* Fixed loosing peers on incoming connections. (#1293)

* Deactivate peer if it has no new data

* Fixed node table timer registration

* Fixed handshake timeout expiration

* Extra trace

* Fixed session count calculation

* Only deactivate incapable peers in ChainHead state

* Timer registration is not needed

* x64 path

* firewall rules

* Fix read-ahead bug.

Re-ahead 8 bytes rather than 3 to ensure large blocks import fine.

* Refactor to use a const.

* Update README.md

* Gas price statistics. (#1291)

* Gas price statistics.

Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265

* Fix a bug in eth_gasPrice

* Fix tests.

* Revert minor alteration.

* Tests for gas_price_statistics.

- Tests;
- Additional infrastructure for generating test blocks with
transactions.

* Key load avoid warning (#1303)

* avoid warning with key

* fix intendations

* more intendation fix

* ok() instead of expect()

* Appveyor config for windows build+installer (#1302)

* appveyor

* proper dist name

* quote

* win-build config

* proper build section

* tests in release

* plugin dir

* cache binaries

* quotes

* escaped quotes

* forces user dir

* fixes

* syntax

* proper cahce dir

* quotes?

* root nsis instead of bin

* submodules init

* artifact path fix

* no submodule

* raw link here

* another way to force cargo cache

* include vc++ 2015 redist

* fix name of the dist

* ETHCORE -> Ethcore

* Disabling ethcore_set* APIs (+ Status page)
gavofyork pushed a commit that referenced this issue Jun 18, 2016
@tomusdrw @gavofyork
Filling-in optional fields of TransactionRequest... (#1305)
5e1e3ce 
* More meaningful errors when sending transaction

* Fixing returned value

* Consolidating all RPC error codes

* Fixed loosing peers on incoming connections. (#1293)

* Deactivate peer if it has no new data

* Fixed node table timer registration

* Fixed handshake timeout expiration

* Extra trace

* Fixed session count calculation

* Only deactivate incapable peers in ChainHead state

* Timer registration is not needed

* x64 path

* firewall rules

* Fix read-ahead bug.

Re-ahead 8 bytes rather than 3 to ensure large blocks import fine.

* Refactor to use a const.

* Update README.md

* Gas price statistics. (#1291)

* Gas price statistics.

Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265

* Fix a bug in eth_gasPrice

* Fix tests.

* Revert minor alteration.

* Tests for gas_price_statistics.

- Tests;
- Additional infrastructure for generating test blocks with
transactions.

* Key load avoid warning (#1303)

* avoid warning with key

* fix intendations

* more intendation fix

* ok() instead of expect()

* Filling-in optional fields of TransactionRequest.

* Adding reference to miner
gavofyork pushed a commit that referenced this issue Jun 18, 2016
@tomusdrw @gavofyork
Bumping topbar. Fixing ws server closing when suspending (#1312)
c1c64be 
* More meaningful errors when sending transaction

* Fixing returned value

* Consolidating all RPC error codes

* Fixed loosing peers on incoming connections. (#1293)

* Deactivate peer if it has no new data

* Fixed node table timer registration

* Fixed handshake timeout expiration

* Extra trace

* Fixed session count calculation

* Only deactivate incapable peers in ChainHead state

* Timer registration is not needed

* x64 path

* firewall rules

* Fix read-ahead bug.

Re-ahead 8 bytes rather than 3 to ensure large blocks import fine.

* Refactor to use a const.

* Update README.md

* Gas price statistics. (#1291)

* Gas price statistics.

Affects eth_gasPrice.
Added ethcore_gasPriceStatistics.

Closes #1265

* Fix a bug in eth_gasPrice

* Fix tests.

* Revert minor alteration.

* Tests for gas_price_statistics.

- Tests;
- Additional infrastructure for generating test blocks with
transactions.

* Key load avoid warning (#1303)

* avoid warning with key

* fix intendations

* more intendation fix

* ok() instead of expect()

* Appveyor config for windows build+installer (#1302)

* appveyor

* proper dist name

* quote

* win-build config

* proper build section

* tests in release

* plugin dir

* cache binaries

* quotes

* escaped quotes

* forces user dir

* fixes

* syntax

* proper cahce dir

* quotes?

* root nsis instead of bin

* submodules init

* artifact path fix

* no submodule

* raw link here

* another way to force cargo cache

* include vc++ 2015 redist

* fix name of the dist

* ETHCORE -> Ethcore

* Bumping topbar. Fixing ws server closing when suspending
@shemnon shemnon mentioned this issue Nov 13, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gavofyork gavofyork

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
1.2 Security
Development

No branches or pull requests
2 participants
@gavofyork @debris