Align the main subscription APIs with the contract subscriptions #2364

jacogr · 2016-09-27T16:27:11Z

Currently in unsubscribe, you need to pass the eventype & subscriptionId - change this to just use the subscriptionId (map this id back to name to get it working properly.)

Mentioned in this PR (I got confused) https://github.com/ethcore/parity/pull/2360

jacogr added F6-refactor 📚 Code needs refactoring. M6-rpcapi 📣 RPC API. labels Sep 27, 2016

ngotchac self-assigned this Oct 24, 2016

ngotchac added a commit that referenced this issue Oct 24, 2016

Removes event name in unsubscribe API + Tests (#2364)

2ed2e11

ngotchac added a commit that referenced this issue Oct 24, 2016

Removes event name in unsubscribe API + Tests (#2364)

cebcc0b

ngotchac mentioned this issue Oct 24, 2016

Remove eventName in unsubscribe API arguments #2844

Merged

jacogr closed this as completed in #2844 Oct 25, 2016

jacogr pushed a commit that referenced this issue Oct 25, 2016

Removes event name in unsubscribe API + Tests (#2364) (#2844)

037a8c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align the main subscription APIs with the contract subscriptions #2364

Align the main subscription APIs with the contract subscriptions #2364

jacogr commented Sep 27, 2016

Align the main subscription APIs with the contract subscriptions #2364

Align the main subscription APIs with the contract subscriptions #2364

Comments

jacogr commented Sep 27, 2016