Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Proper multisig wallet support #3282

Closed
jacogr opened this issue Nov 8, 2016 · 3 comments · Fixed by #3700
Closed

Proper multisig wallet support #3282

jacogr opened this issue Nov 8, 2016 · 3 comments · Fixed by #3700
Assignees
@ngotchac
Labels
F8-enhancement 🎊 An additional feature request. P5-sometimesoon 🌲 Issue is worth doing soon.

Comments

@jacogr
Copy link
Contributor

jacogr commented Nov 8, 2016 •
edited
Loading

  • listing of balances
  • first-class transfer of value
  • ease of wallet deployment (proper parameter settings)
@jacogr jacogr added F8-enhancement 🎊 An additional feature request. M6-ui P5-sometimesoon 🌲 Issue is worth doing soon. labels Nov 8, 2016
@jacogr jacogr mentioned this issue Nov 9, 2016
Closed
@chevdor chevdor mentioned this issue Nov 11, 2016
Closed
@jacogr jacogr mentioned this issue Nov 11, 2016
Closed
@jacogr
Copy link
Contributor Author

jacogr commented Nov 11, 2016 •
edited
Loading

Ricardo Guilherme Schmidt @3esmit 21:09
Today I discovered the Multisig Wallet from Stefan George - [email protected] by looking at Golem Project Multisig Sources
You will use that, or the one Gav Wood developed?
https://github.com/ConsenSys/MultiSigWallet
@jacogr Thanks, that would be very useful.

Jaco Greeff @jacogr 21:17
There are a number of touch points -

  1. Existing wallets will need to be attached and available as first-class citizens, regardless of the source - this makes migration from existing wallets easy (user choice is important)
  2. We will certainly look at what gives us most bang-for-the-buck for the cases where users deploy new multisig wallets - users need to win and have the best solution at the end of the day (As such I will like to copy your comment above into the linked issue, unless you have done so already)

Having said all that, the original wallet is very well tested and widely used, and we may just innovate on the UX layer.

(As an aside, this recently landed in master - we make the cases where users attach known contracts easier - ethcore/parity#3310, in this case multisig is the original multisig. First prize for us is obviously if users don't need to resort to digging around contract internals)

As per Gavin, sticking to the original is the best route, comment linked for the sake of tracking.

ngotchac added a commit that referenced this issue Nov 22, 2016
@ngotchac
Wallet Creation Modal #3282
19dbe3f
ngotchac added a commit that referenced this issue Nov 22, 2016
@ngotchac
Name and description to Wallet #3282
5d2aa44
@jacogr jacogr mentioned this issue Nov 23, 2016
Closed
ngotchac added a commit that referenced this issue Nov 29, 2016
@ngotchac
Add Wallet to the Account Page and Wallet Page #3282
13383cf
ngotchac added a commit that referenced this issue Nov 30, 2016
@ngotchac
Basic Details for Wallet #3282
4f39eab
ngotchac added a commit that referenced this issue Nov 30, 2016
@ngotchac
Working wallet init transfer #3282
88df273
ngotchac added a commit that referenced this issue Nov 30, 2016
@ngotchac
Show confirmations for Wallet #3282
152b31d
ngotchac added a commit that referenced this issue Dec 1, 2016
@ngotchac
MultiSig txs and confirm pending #3282
124f534
ngotchac added a commit that referenced this issue Dec 1, 2016
@ngotchac
MultiSig Wallet Revoke #3282
f200fa2
ngotchac added a commit that referenced this issue Dec 1, 2016
@ngotchac
Confirmations and Txs Update #3282
bc8ce41
ngotchac added a commit that referenced this issue Dec 1, 2016
@ngotchac
Feedback for Confirmations #3282
83d4d8a
@ngotchac ngotchac mentioned this issue Dec 1, 2016
Merged
ngotchac added a commit that referenced this issue Dec 5, 2016
@ngotchac
Working Token transfer for multi-sig wallet #3282
243f1c7
ngotchac added a commit that referenced this issue Dec 5, 2016
@ngotchac
Add existing wallet from address #3282
3d93c6b
jacogr pushed a commit that referenced this issue Dec 6, 2016
@ngotchac @jacogr
First draft of the MultiSig Wallet (#3700)
bec3539 
* Wallet Creation Modal #3282

* Name and description to Wallet #3282

* Add Wallet to the Account Page and Wallet Page #3282

* Fix Linting

* Crete MobX store for Transfer modal

* WIP Wallet Redux Store

* Basic Details for Wallet #3282

* Fixing linting

* Refactoring Transfer store for Wallet

* Working wallet init transfer #3282

* Optional gas in MethodDecoding + better input

* Show confirmations for Wallet #3282

* Order confirmations

* Method Decoding selections

* MultiSig txs and confirm pending #3282

* MultiSig Wallet Revoke #3282

* Confirmations and Txs Update #3282

* Feedback for Confirmations #3282

* Merging master fixes...

* Remove unused CSS
@jacogr jacogr reopened this Dec 6, 2016
ngotchac added a commit that referenced this issue Dec 6, 2016
@ngotchac
Working Token transfer for multi-sig wallet #3282
e0fef73
ngotchac added a commit that referenced this issue Dec 6, 2016
@ngotchac
Add existing wallet from address #3282
c968d88
ngotchac added a commit that referenced this issue Dec 6, 2016
@ngotchac
Wallet delete redirect to Wallets/Accounts #3282
972a13d
ngotchac added a commit that referenced this issue Dec 6, 2016
@ngotchac
Rightly check balance in Transfer // Get all accounts balances #3282
444017b
@ngotchac ngotchac mentioned this issue Dec 6, 2016
Merged
jacogr pushed a commit that referenced this issue Dec 7, 2016
@ngotchac @jacogr
Add functionalities to multi-sig wallet (#3729)
8dbd568 
* WIP Sending tokens in multi-sig wallet

* Working Token transfer for multi-sig wallet #3282

* Add operation hash to transfer modal

* Add existing wallet from address #3282

* Wallet delete redirect to Wallets/Accounts #3282

* Rightly check balance in Transfer // Get all accounts balances #3282

* Fix linting

* Better Header UI for Wallet

* Use the `~` webpack alias

* Use Webpack `~` alias
ngotchac added a commit that referenced this issue Dec 7, 2016
@ngotchac
Update dailylimit #3282
caabfbc
ngotchac added a commit that referenced this issue Dec 7, 2016
@ngotchac
WIP Wallet settings modification #3282
0513066
ngotchac added a commit that referenced this issue Dec 7, 2016
@ngotchac
WIP edit contract parameters #3282
2152b8f
ngotchac added a commit that referenced this issue Dec 7, 2016
@ngotchac
Edit Wallet parameters #3282
43fe15f
ngotchac added a commit that referenced this issue Dec 7, 2016
@ngotchac
Fix Transfer for Wallet #3282
f909557
jacogr pushed a commit that referenced this issue Dec 8, 2016
@ngotchac @jacogr
Edit Multisig Wallet settings (#3740)
715761a 
* WIP Sending tokens in multi-sig wallet

* Working Token transfer for multi-sig wallet #3282

* Add operation hash to transfer modal

* Add existing wallet from address #3282

* Wallet delete redirect to Wallets/Accounts #3282

* Rightly check balance in Transfer // Get all accounts balances #3282

* Fix linting

* Better Header UI for Wallet

* Use the `~` webpack alias

* Use Webpack `~` alias

* Add `ETH` format to number typed input

* Fix wallet creation hint && eth input type

* Update dailylimit #3282

* Fix too long copied message

* WIP Wallet settings modification #3282

* WIP edit contract parameters #3282

* Edit Wallet parameters #3282

* Don't show wallets if none

* Fix Transfer for Wallet #3282

* Optimized version of contract code

* Fix wrong max in Wallet creation // Round gas in API
ngotchac added a commit that referenced this issue Dec 9, 2016
@ngotchac
Make Wallet Mist compatible #3282
837caac
jacogr pushed a commit that referenced this issue Dec 10, 2016
@ngotchac @jacogr
Add support for wallets without getOwner() interface (#3779)
6655e7e 
* Make Wallet Mist compatible #3282

* Owners icons on load

* Fix oversized logo on load

* Don't fetch registry twice (even when pending)

* Better logging...

* Better contract view : show if no events // show loading events

* Better decimal typed input

* PR grumble
@ngotchac
Copy link
Contributor

ngotchac commented Jan 3, 2017

All basic functionalities of the Wallet have been implemented. Closing this issue in favor of smaller ones if needed.

@ngotchac ngotchac closed this as completed Jan 3, 2017
@knocte
Copy link

knocte commented Jan 24, 2017

Does this mean that we will not see "Proper multisig wallet support" in the stable branch? Can at least the bugfixes backported to 1.4.vNext?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ngotchac ngotchac

Labels
F8-enhancement 🎊 An additional feature request. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First draft of the MultiSig Wallet openethereum/parity-ethereum
3 participants
@knocte @jacogr @ngotchac