Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

When importing accounts, use better name than UUID #3368

Closed
jacogr opened this issue Nov 11, 2016 · 0 comments
Closed

When importing accounts, use better name than UUID #3368

jacogr opened this issue Nov 11, 2016 · 0 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@jacogr
Copy link
Contributor

jacogr commented Nov 11, 2016

Jaco Greeff @jacogr 14:29
@sammy007 That is the UUID - it should show the actual account name when a match is found. I'm guessing for this account the name is the same as the UUID.
For the second part, you are right, there is an overflow issue it would seem.

Sammy Libre @sammy007 14:30
I pasted 5631aa24f7d75a0b0be4f3294b2a250db790a226 (without 0x0) and definitely i’d like to see what i pasted not a magic different representation of address, because we are still humans (I want to believe).
This is really weird idea to replace it with something users not familiar with.

Jaco Greeff @jacogr 14:31
When you paste and it is your account, it will show you the name of the account, not the address. We opted to everywhere display the account names and not the addresses (for known accounts).
For unknown accounts (i.e. not yours and not in your addressbook), the address will show. Showing the name is a bit more human than trying to remember a long hex string.

Sammy Libre @sammy007 14:33
Consider fallback to exact representation until account name is specified for address, this is new adddress i generated

@jacogr jacogr added F2-bug 🐞 The client fails to follow expected behavior. M7-ui labels Nov 11, 2016
@gavofyork gavofyork changed the title When name == uuid don't display the name, display address When importing accounts, use better string than UUID Nov 12, 2016
@gavofyork gavofyork changed the title When importing accounts, use better string than UUID When importing accounts, use better name than UUID Nov 12, 2016
@gavofyork gavofyork added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. and removed F2-bug 🐞 The client fails to follow expected behavior. M7-ui labels Nov 12, 2016
@gavofyork gavofyork added this to the 1.5 Tenuity milestone Nov 12, 2016
@gavofyork gavofyork self-assigned this Nov 12, 2016
gavofyork added a commit that referenced this issue Nov 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

2 participants