This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Bloomchain #1014
Merged
Bloomchain #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
the
A3-inprogress ⏳
debris
added
A0-pleasereview 🤓
| @@ -113,6 +113,7 @@ fn setup_rpc_server(apis: Vec<&str>, deps: &Arc<Dependencies>) -> Server { | |||
| server.add_delegate(EthcoreClient::new(&deps.miner, deps.logger.clone(), deps.settings.clone()).to_delegate()) | |||
| }, | |||
| "traces" => { | |||
| // not adding to modules, since `traces` is not supported in geth | |||
There was a problem hiding this comment.
right! incorrect merge 👍
|
might be worth staging somewhere other than master or we'll be resyncing multiple times with the current DB changes... |
|
I can keep this pr up to date until there is a right moment to merge it |
gavofyork
added
A1-onice 🌨
|
btw can't the database be auto-upgraded somehow? |
debris
added
A0-pleasereview 🤓
|
Added migrations |
| let mut result = H264::default(); | ||
| result[0] = i as u8; | ||
| unsafe { | ||
| ptr::copy(hash.as_ptr(), result.as_mut_ptr().offset(1), 32); |
There was a problem hiding this comment.
prefer clone_from_slice to unsafe code.
let result_key = &mut result[1 .. ];
result_key.clone_from_slice(hash);
arkpar
added
A5-grumble 🔥
…problem from trace/db.rs
debris
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
| } | ||
|
|
||
| struct CacheManager { | ||
| cache_usage: VecDeque<HashSet<CacheID>>, | ||
| in_use: HashSet<CacheID>, | ||
| } | ||
|
|
||
| impl bc::group::BloomGroupDatabase for BlockChain { | ||
| fn blooms_at(&self, position: &bc::group::GroupPosition) -> Option<bc::group::BloomGroup> { | ||
|
|
gavofyork
added
A5-grumble 🔥
debris
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #996 and #997
small fixes, optimizations and removing duplicated logic
blockchain::BlockChainConfigmoved to its own file and renamed to justConfigchainfiltermodule and everything related to it, eg.blockchain::BloomIndexer. Usebloomchaincrate instead.BlocksBloomsdatabase keys are smaller - 6 bytes (33 bytes before).BlockHashesdatabase keys are smaller - 5 bytes( 33 bytes before).6.0