This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
update ring to 0.14 #10262
Merged
update ring to 0.14 #10262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
* master: Fix join-set test to be deterministic. (#10263)
niklasad1
reviewed
Jan 30, 2019
niklasad1
approved these changes
Jan 30, 2019
niklasad1
added
A8-looksgood 🦄
tomaka
suggested changes
Feb 3, 2019
| use super::{Crypto, Error}; | ||
| use super::{Crypto, Error, NonZeroU32}; | ||
|
|
||
| const ITERATIONS: NonZeroU32 = unsafe { NonZeroU32::new_unchecked(10240) }; |
There was a problem hiding this comment.
Although this is technically safe, by ideology it's probably better to not use any unsafe anywhere.
There was a problem hiding this comment.
by ideology it's probably better to not use any unsafe anywhere
Well, I don't think we should treat "don't use unsafe" as a dogma. The are different kinds of unsafe code. Here the unsafety of new_unchecked comes from const-control-flow (and probably const_panic) being unstable.
And, in this case, for literals and constants it's easy to reason about the safety.
Nevertheless, I've eliminated all the calls to new_unchecked.
sorpaas
approved these changes
Feb 5, 2019
tomaka
approved these changes
Feb 5, 2019
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: fix: parity-clib/examples/cpp/CMakeLists.txt (#10313) CI optimizations (#10297) Increase number of requested block bodies in chain sync (#10247) Deprecate account management (#10213) Properly handle check_epoch_end_signal errors (#10015) fix(osx and windows builds): bump parity-daemonize (#10291) Add missing step for Using `systemd` service file (#10175) Call private contract methods from another private contract (read-only) (#10086) update ring to 0.14 (#10262) fix(secret-store): deprecation warning (#10301) Update to jsonrpc-derive 10.0.2, fixes aliases bug (#10300) Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is necessary, since ring 0.13 is going to be yanked soon.
Change from
u32toNonZeroU32in parity-crypto was pretty invasive (b347599)