Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

license update #11543

Merged
merged 3 commits into from
Mar 5, 2020
Merged

license update #11543

merged 3 commits into from
Mar 5, 2020

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Mar 4, 2020

extracted from #11542


// You should have received a copy of the GNU General Public License
// along with Open Ethereum. If not, see <http://www.gnu.org/licenses/>.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this file missing a license header? :)

Copy link
Collaborator

@niklasad1 niklasad1 Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably my fault when I refactored to use ethereum-types in RPC and forgot to add the license header apparentely.

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 4, 2020
@ordian ordian mentioned this pull request Mar 4, 2020
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license header in util/EIP-152/src/portable.rs is not updated, can you fix it?

Otherwise looks good.

@ordian
Copy link
Collaborator Author

ordian commented Mar 5, 2020

The license header in util/EIP-152/src/portable.rs is not updated, can you fix it?

Good catch! Somehow the script didn't fix it.

@niklasad1
Copy link
Collaborator

Good catch! Somehow the script didn't fix it.

The script is hacky :)

I wrote it but assumes a new line after the license header which util/EIP-152/src/portable.rs don't have 👀

@ordian ordian merged commit 3ccfe73 into master Mar 5, 2020
@ordian ordian deleted the ao-license-update branch March 5, 2020 11:19
ordian added a commit that referenced this pull request Mar 6, 2020
* master:
  ethcore: cleanup after #11531 (#11546)
  license update (#11543)
  Less cloning when importing blocks (#11531)
  Github Actions (#11528)
  Fix Alpine Dockerfile (#11538)
  Remove AuxiliaryData/AuxiliaryRequest (#11533)
  [journaldb]: cleanup (#11534)
ordian added a commit that referenced this pull request Mar 10, 2020
* master:
  Code cleanup in the sync module (#11552)
  initial cleanup (#11542)
  Warn if genesis constructor revert (#11550)
  ethcore: cleanup after #11531 (#11546)
  license update (#11543)
  Less cloning when importing blocks (#11531)
  Github Actions (#11528)
  Fix Alpine Dockerfile (#11538)
  Remove AuxiliaryData/AuxiliaryRequest (#11533)
  [journaldb]: cleanup (#11534)
  Remove references to parity-ethereum (#11525)
  Drop IPFS support (#11532)
  chain-supplier: fix warning reporting for GetNodeData request (#11530)
  Faster kill_garbage (#11514)
  [EngineSigner]: don't sign message with only zeroes (#11524)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants