This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bump memory-db lib to 0.24.1 and add shrink_to_fit #11760 #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested for four days, everything function as expected. |
ordian
reviewed
Jul 27, 2020
adria0
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rakita
force-pushed
the
rakita/shrink_to_fit
branch
from
July 28, 2020 10:54
f38b94c
to
576c326
Compare
Not sure why, but test unrelated to this pull request fails on macos: command is
|
rakita
force-pushed
the
rakita/shrink_to_fit
branch
3 times, most recently
from
July 29, 2020 11:58
c51138e
to
b27bfa5
Compare
sorpaas
added
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
M4-core ⛓
Core client code / Rust.
labels
Jul 29, 2020
sorpaas
approved these changes
Jul 29, 2020
rakita
force-pushed
the
rakita/shrink_to_fit
branch
from
July 31, 2020 12:21
5cd4424
to
576c326
Compare
Blocked. The test fails on macos because of updated memory-db and I don't have platform to debug this. |
vorot93
approved these changes
Jul 31, 2020
Test failure is not related to this pull request. |
sorpaas
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
labels
Aug 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory-db lib
to0.24.1
and add shrink_to_fitoverlay.cumulative_size
instead ofoverlay.backing_overlay.size_of(..)
It is more inaccurate but it is good enough and a it will allow us to skip heavysize_of
.