This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Merged
Windows build #1253
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0bde846
Networking refactoring
arkpar 7afaae8
Fixed typo
arkpar d0a55c2
Trace logging
arkpar c5eca60
Updated dependencies for windows build
arkpar 765e5f7
Merge branch 'master' of https://github.com/ethcore/parity into HEAD
e937d13
Windows fixes
9c611a4
use mio 0.5
8edf5db
nix build
arkpar f463826
Merge branch 'master' of github.com:ethcore/parity into windows
arkpar f91132d
Windows build fix
892cb89
style
arkpar 87611b0
removed unused import
arkpar 3e0a79c
ipc crate version bump
NikVolf 3ebc4aa
ipc config for named pipes
NikVolf 889ac96
tweaks and fixes
NikVolf 6f4e01a
tweaks and fixes
NikVolf 86f7bcc
final version bump
NikVolf f6582e7
Merge pull request #1254 from ethcore/windows-pipes
arkpar 2faa688
Fixed tests
arkpar e86d5a0
Disable color output on windows
arkpar ad791e1
Added missing doc
arkpar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -466,6 +466,7 @@ pub struct KeyDirectory { | |
} | ||
|
||
/// Restricts the permissions of given path only to the owner. | ||
#[cfg(not(windows))] | ||
pub fn restrict_permissions_owner(file_path: &Path) -> Result<(), i32> { | ||
let cstr = ::std::ffi::CString::new(file_path.to_str().unwrap()).unwrap(); | ||
match unsafe { ::libc::chmod(cstr.as_ptr(), ::libc::S_IWUSR | ::libc::S_IRUSR) } { | ||
|
@@ -474,6 +475,12 @@ pub fn restrict_permissions_owner(file_path: &Path) -> Result<(), i32> { | |
} | ||
} | ||
|
||
#[cfg(windows)] | ||
pub fn restrict_permissions_owner(_file_path: &Path) -> Result<(), i32> { | ||
//TODO: implement me | ||
Ok(()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does having this unimplemented create a potential security hole on windows? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't thinks so |
||
} | ||
|
||
impl KeyDirectory { | ||
/// Initializes new cache directory context with a given `path` | ||
pub fn new(path: &Path) -> KeyDirectory { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no docs for windows version btw