This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Client API refactoring - limiting errors to crate-level error types #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seems to have added code and faff with no obvious reasons for it. |
|
@gavofyork needed for rpc api |
arkpar
added
A8-looksgood 🦄
|
|
||
| /// Api-level error for transaction import | ||
| #[derive(Debug, Clone, Binary)] | ||
| pub enum TransactionImportError { |
There was a problem hiding this comment.
Is this type necessary? Can't we just use TransactionError?
| fn from(e: Error) -> Self { | ||
| match e { | ||
| Error::Transaction(transaction_error) => TransactionImportError::Transaction(transaction_error), | ||
| _ => TransactionImportError::Other(format!("other block import error: {:?}", e)), |
There was a problem hiding this comment.
imo, we should never do this type of conversion, cause it makes TransactionImportError more generic then Error
|
I see that this pr is already merged. I generally like the changes that it introduced, but it needs some polishing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.