This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix logging #1590
Merged
Fix logging #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A8-looksgood 🦄
| if let &Some(ref f) = &file { | ||
| // ignore errors - there's nothing we can do | ||
| let _ = f.locked().write_all(removed_color.as_bytes()); | ||
| let _ = f.locked().write_all(b"\n"); |
There was a problem hiding this comment.
why lock twice?
there is also an implementation of write for &'a File, meaning you could probably avoid the mutex altogether and just pass a file handle
rphmeier
added
A5-grumble 🔥
|
lgtm other than mutex grumble |
|
Would be nice to disable colours for non-terminal output. Can be checked with |
another PR i think |
gavofyork
added
A0-pleasereview 🤓
|
still unnecessarily uses a mutex. i have a commit which fixes this at rphmeier@7336442 which i can push to this branch as well |
rphmeier
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--log-filefor redirecting logging to a file.