Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

take snapshot at specified block and slightly better informants #1873

Merged
merged 4 commits into from
Aug 8, 2016

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Aug 8, 2016

Fixes #1859
Fixes #1857

This does fail immediately if the block is older than HISTORY and the database is pruned. I don't see any other course of action but feel free to recommend one.

@rphmeier rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Aug 8, 2016
@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage increased (+0.05%) to 86.34% when pulling 5f9c1b5 on snapshot_informants into 3f26169 on master.

@@ -231,6 +231,12 @@ Import/Export Options:
--format FORMAT For import/export in given format. FORMAT must be
one of 'hex' and 'binary'.

Snapshot Options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is latest the latest - 1000?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2016
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Aug 8, 2016
@gavofyork gavofyork merged commit 2f1ade8 into master Aug 8, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 8, 2016
@gavofyork gavofyork deleted the snapshot_informants branch August 8, 2016 16:41
arkpar pushed a commit that referenced this pull request Aug 9, 2016
* prettier informant for snapshot creation

* allow taking snapshot at a given block

* minor tweaks

* elaborate on cli
arkpar added a commit that referenced this pull request Aug 9, 2016
* Sync to peers with confirmed fork block only (#1863)

* Fixing gas conversion

* Validating u256->usize conversion

* Update cache usage on commiting block info (#1871)

* Use UntrustedRlp for block verification (#1872)

* take snapshot at specified block and slightly better informants (#1873)

* prettier informant for snapshot creation

* allow taking snapshot at a given block

* minor tweaks

* elaborate on cli

* Send new block hashes to all peers (#1875)

* Reduce max open files (#1876)

* ws-rs update

* Fixing test

* Fixing miner deadlock (#1885)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants