This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Asynchronous RPC support #2017
Merged
Asynchronous RPC support #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: rpc/src/v1/impls/ethcore.rs rpc/src/v1/impls/personal.rs
tomusdrw
added
A0-pleasereview 🤓
Conflicts: rpc/src/v1/impls/ethcore.rs rpc/src/v1/impls/personal.rs
tomusdrw
removed
the
A3-inprogress ⏳
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| use hyper::{server, net}; | |||
| use std::collections::BTreeMap; | |||
| pub use hyper::Control; | |||
There was a problem hiding this comment.
I wanted to keep Endpoints decoupled from hyper. Maybe it would be better to have custom Control wrapper instead (perhaps with better name).
added 2 commits
August 30, 2016 16:47
Conflicts: Cargo.lock dapps/Cargo.toml dapps/src/apps/fetcher.rs
|
@debris Please review this |
| @@ -16,7 +16,7 @@ git: | |||
| matrix: | |||
| include: | |||
| - rust: stable | |||
| env: RUN_TESTS="true" | |||
| env: RUN_TESTS="true" TEST_OPTIONS="--no-release" | |||
There was a problem hiding this comment.
does this set tests to run in debug mode?
There was a problem hiding this comment.
Yes, but only on stable compiler. Otherwise travis was timeing out (I was trying to re-run couple of times). Suprisingly it's a bit faster when running without release on stable.
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonrpc-core)Thanks for help: @debris & @rphmeier