This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fetching content from HTTPS using rustls
#2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 29, 2016 16:34
Conflicts: Cargo.lock dapps/src/handlers/fetch.rs
| @@ -67,7 +67,7 @@ impl<T> Hashable for T where T: BytesConvertable { | |||
| } | |||
|
|
|||
| /// Calculate SHA3 of given stream. | |||
| pub fn sha3<R: io::Read>(r: &mut R) -> Result<H256, io::Error> { | |||
| pub fn sha3<R: io::Read>(r: &mut io::BufReader<R>) -> Result<H256, io::Error> { | |||
There was a problem hiding this comment.
Isn't there a BufRead trait for this?
arkpar
added
A5-grumble 🔥
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
|
needs rebase |
Conflicts: Cargo.lock
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
rphmeier
added
A7-looksgoodcantmerge 🙄
Conflicts: Cargo.lock
tomusdrw
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
| } | ||
|
|
||
| fn is_aborted(&self) -> bool { | ||
| self.abort.load(Ordering::Relaxed) |
There was a problem hiding this comment.
Really should use SeqCst everywhere unless there's a good reason not to. It's not slower on x86 but it is not worth risking memory ordering bugs (which are awful) just to shave off a couple nanoseconds on other architectures.
There was a problem hiding this comment.
There might be only one state transition here: false->true and even if it's not correctly detected there are no particularly bad consequences (the content will be just fetched till the end and removed after that).
I'm ok with SeqCst - it's not hot code at all and if we can avoid some bugs because of that then 👍 :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1176