Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Import command summary #2102

Merged
merged 2 commits into from
Sep 16, 2016
Merged

Import command summary #2102

merged 2 commits into from
Sep 16, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Sep 15, 2016

No description provided.

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Sep 15, 2016
rphmeier
rphmeier reviewed Sep 15, 2016
View reviewed changes
parity/informant.rs
@@ -41,7 +41,7 @@ pub struct Informant {
skipped: AtomicUsize,
}

trait MillisecondDuration {
pub trait MillisecondDuration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the as_milliseconds function are missing docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 85.275% when pulling cc845c6 on import-stats into c16bf7f on master.

@rphmeier rphmeier added M4-core ⛓ Core client code / Rust. A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 15, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 85.269% when pulling 0124f98 on import-stats into c16bf7f on master.

@rphmeier rphmeier merged commit 851b639 into master Sep 16, 2016
@rphmeier rphmeier deleted the import-stats branch September 16, 2016 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkpar @coveralls @rphmeier