This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Removing panickers from sync module #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
arkpar
commented
Oct 9, 2016
| trace!(target: "sync", "Sending NewHashes to {:?}", peers); | ||
| let mut sent = 0; | ||
| let last_parent = HeaderView::new(&io.chain().block_header(BlockID::Hash(chain_info.best_block_hash.clone())).unwrap()).parent_hash(); | ||
| for &(peer_id, peer_number) in peers { | ||
| let peer_best = if chain_info.best_block_number - peer_number > MAX_PEER_LAG_PROPAGATION as BlockNumber { |
There was a problem hiding this comment.
This check does not really work since there's no reliable way to check peer's best block. I'm going to add a hashset of recently sent blocks/hashes per peer in a future PR instead.
arkpar
changed the title
rphmeier
added
A8-looksgood 🦄
arkpar
added a commit
that referenced
this pull request
Oct 11, 2016
arkpar
added a commit
that referenced
this pull request
Oct 11, 2016
* v1.3.6 * Print backtrace on panic (#2535) * Don't activate peers on connect; Test (#2537) * Removing unwarps from sync module (#2551) * Remove unwrap from client module (#2554) * remove unwraps in client * imporve block hash expect message * mining perf trace * Fixed race condition in trace import (#2555)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.