This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix issues with no ethereum test dir present (2382) #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 1cb0e26 on fix-2382 into * on master*. |
tomusdrw
reviewed
Oct 17, 2016
| let geth_path = path::ethereum::default(); | ||
| ::std::fs::create_dir_all(geth_path.as_path()).unwrap_or_else( | ||
| |e| warn!("Failed to create '{}' for geth mode: {}", &geth_path.to_str().unwrap(), e)); | ||
| if self.args.flag_geth && !cfg!(windows) { |
There was a problem hiding this comment.
What's wrong with Windows?
There was a problem hiding this comment.
no need to create directory for windows pipe, it is in no way related to the file system (unlike unix sockets)
and afaik we don't implicitly use geth dir for anything but ipc now
There was a problem hiding this comment.
I see, it's probably used in geth imports, but I think it handles missing directories correctly.
gavofyork
added
A8-looksgood 🦄
tomusdrw
pushed a commit
that referenced
this pull request
Oct 19, 2016
gavofyork
pushed a commit
that referenced
this pull request
Oct 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2382