Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Personal split #2879

Merged
merged 4 commits into from
Oct 27, 2016
Merged

Personal split #2879

merged 4 commits into from
Oct 27, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 26, 2016

Split personal_* RPC into safe & unsafe parts. End-result is that the safe parts are available to dapps as well, which includes

  • personal_accountsInfo
  • personal_listAccounts
  • personal_listGethAccounts

Does the split on the Rust side and re-enables the use of personal_accountsInfo on the dapps side (used for mapping accounts to names)

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M5-ui labels Oct 26, 2016
@tomusdrw
Copy link
Collaborator

I'm not sure if any dapps are already relying on personal_unlockAccount or personal_signAndSendTransaction to be exposed.

For backward compatibility we could expose those methods, but slightly modified:

  1. Instead of expecting a password to decrypt the key it would expect single-use password.
  2. Such password could be generated in secure signer.
    or
  3. We can accept any password there
  4. Convert it to standard Signing request

Just leaving it here if we ever consider that.

@jacogr
Copy link
Contributor Author

jacogr commented Oct 26, 2016

Found a couple of subtle issues where the initial rush to remove all personal_accountsinfo didn't catch the corner cases. Since the JS side basically moves back to prior to personal-being-completely-locked, it will solve some nigglies in the dapps.

@jacogr
Copy link
Contributor Author

jacogr commented Oct 27, 2016

@gavofyork As discussed, @tomusdrw made the changes so safe is now only listAccounts & accountsInfo. Please review, would like to get this in and humming.

@rphmeier
Copy link
Contributor

Core portion LGTM. Personal looks like it can be easily ported to auto_args now. The signer return values are still blocking the other personal APIs.

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 27, 2016
@rphmeier
Copy link
Contributor

(would like a UI sign-off as well)

@jacogr
Copy link
Contributor Author

jacogr commented Oct 27, 2016

UI was just a revert of the previous half-fix when it was removed. All dapps tested on this branch.

@jacogr
Copy link
Contributor Author

jacogr commented Oct 27, 2016

@ngotchac Ping.

@ngotchac
Copy link
Contributor

Looks good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants