-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
I'm not sure if any dapps are already relying on For backward compatibility we could expose those methods, but slightly modified:
Just leaving it here if we ever consider that. |
Found a couple of subtle issues where the initial rush to remove all |
@gavofyork As discussed, @tomusdrw made the changes so safe is now only |
Core portion LGTM. |
(would like a UI sign-off as well) |
UI was just a revert of the previous half-fix when it was removed. All dapps tested on this branch. |
@ngotchac Ping. |
Looks good to me |
Split personal_* RPC into safe & unsafe parts. End-result is that the safe parts are available to dapps as well, which includes
personal_accountsInfo
personal_listAccounts
personal_listGethAccounts
Does the split on the Rust side and re-enables the use of personal_accountsInfo on the dapps side (used for mapping accounts to names)