Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Snapshot sync and block gap info in eth_syncing #2948

Merged
merged 9 commits into from
Oct 31, 2016
Merged

Conversation

rphmeier
Copy link
Contributor

Closes #2939.

Adds fields to sync info structure returned from eth_syncing.
These fields are null when irrelevant.
blockGap: array of "first", "last", such that [first, last) are all missing from the chain.
warpChunksAmount: total amount of snapshot chunks.
warpChunksProcessed amount of snapshot chunks processed.

@jacogr All yours!

@rphmeier rphmeier added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API. labels Oct 28, 2016
@jacogr
Copy link
Contributor

jacogr commented Oct 29, 2016

Just a basic question - in light of https://github.com/ethcore/parity/issues/2969 do we really want to extend the standard method?

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 29, 2016
@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 29, 2016
@gavofyork
Copy link
Contributor

@rphmeier can't build (a couple of warnings by the looks of it)

@gavofyork
Copy link
Contributor

@jacogr yeah it's fine - we can do it in one big batch.

@rphmeier
Copy link
Contributor Author

@gavofyork Yeah, just a test I forgot to update. I'll add serialization tests for the new fields as well.

@rphmeier
Copy link
Contributor Author

@tomusdrw will the new object format break the old UI?

@gavofyork
Copy link
Contributor

old UI? i don't think there's any of that left, is there?

@tomusdrw
Copy link
Collaborator

Yes, old UI is gone (maybe just chrome extension left), but we were never relying on that method anyway.

Since the change is additive it shouldn't also break any web3-based dapps (i.e. Mist)

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Oct 31, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 009dde4 on snapshot-syncing-rpc into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 70fc7cb on snapshot-syncing-rpc into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 70fc7cb on snapshot-syncing-rpc into * on master*.

@rphmeier
Copy link
Contributor Author

The Old UI will still exist in the 1.3.x series. I'd heard it was broken by previous additive changes to RPC, just keeping an eye out. Are we officially taking the position that the old UI is completely unsupported?

@gavofyork
Copy link
Contributor

that is right.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 31, 2016
@gavofyork
Copy link
Contributor

travis passing, so will assuming is good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants