Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Handle contract constructor inputs #3430

Merged
merged 12 commits into from
Nov 15, 2016
Merged

Handle contract constructor inputs #3430

merged 12 commits into from
Nov 15, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Nov 14, 2016

Fixes #3314 and fixes #3395 and closes #3393

Try contract deployment with this ABI:

[
   {
      "inputs":[
         {
            "name":"_owners",
            "type":"address[]"
         },
         {
            "name":"_ownersS",
            "type":"string[2]"
         },
         {
            "name":"_int",
            "type":"int256"
         },
         {
            "name":"_string",
            "type":"string"
         },
         {
            "name":"_bytes",
            "type":"bytes"
         },
         {
            "name":"_uint",
            "type":"uint256"
         }
      ],
      "type":"constructor"
   }
]

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Nov 14, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2944267 on ng-array-parameters into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5322727 on ng-array-parameters into * on master*.

@jacogr
Copy link
Contributor

jacogr commented Nov 14, 2016

@ngotchac Will review first thing in the morning. (Have been through the code, nothing critical pops up, however need to pull down and play with this one as well)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 125ac1a on ng-array-parameters into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 125ac1a on ng-array-parameters into * on master*.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 15, 2016
@jacogr jacogr merged commit 28f11be into master Nov 15, 2016
@jacogr jacogr deleted the ng-array-parameters branch November 15, 2016 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
3 participants