Add Email and Registry lookups to Address Selector #3992
Conversation
|
Changes Unknown when pulling 76496bb on ng-address-from-regs into ** on master**. |
| const { address, value } = regsitryValue; | ||
| const account = { address, name: value, index: address }; | ||
|
|
||
| .map((regsitryValue, index) => { |
| .instance | ||
| .reverse.call({}, [ sha3(value) ]); | ||
| }, | ||
| describe: (value) => `${value} (from email verification)` |
There was a problem hiding this comment.
I'd prefer "Verified using email …", as this is being shown inside and account card.
There was a problem hiding this comment.
While we are doing this fresh, create strings with FormattedMessage so we don't need to circle back. (Also for the labels in this store)
| @@ -52,6 +52,11 @@ | |||
| } | |||
| } | |||
|
|
|||
| .description { | |||
| font-size: 0.75em; | |||
| color: rgba(255, 255, 255, 0.498039); | |||
There was a problem hiding this comment.
Make it 0.5 alpha, Chrome creates these numbers when inspecting.
| return registryInstance | ||
| .getAddress.call({}, [ sha3(value), 'A' ]); | ||
| }, | ||
| describe: (value) => `${value} (from registry)` |
There was a problem hiding this comment.
<FormattedMessage
id='addressSelect.fromRegistry'
defaultMessage='{value} (from registry)'
values={ {
value
} } />
| .filterValues(category.values, value) | ||
| .map((value) => { | ||
| index++; | ||
| return { ...value, index: parseInt(index) }; |
There was a problem hiding this comment.
Would prefer
return {
index: parseInt(index),
...value
};
| } | ||
|
|
||
| const account = flatMap(this.initValues, (cat) => cat.values) | ||
| .find((account) => account.address.toLowerCase() === result.toLowerCase()); |
There was a problem hiding this comment.
Do we need to lowercase result each callback? Could do it outside and assign to variable being tested.
|
|
||
| this.initValues = [ | ||
| { | ||
| label: 'accounts', |
There was a problem hiding this comment.
Labels as per comment above.
| return null; | ||
| } | ||
|
|
||
| const accounts = regsitryValues |
There was a problem hiding this comment.
registryValues (typo, also registryValue below as well as the function name)
|
Fixed |
jacogr
added
A7-looksgoodtestsfail 🤖
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling 53e5b4c on ng-address-from-regs into ** on master**. |
Closes #3871
Adds to the new Address Selector lookups capabilities from the Registry and the Email Verification contract.
The result is shown right under the input.
It also fixes some issues in the component.