This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a password strength component #4153
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2015, 2016 Parity Technologies (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
export default from './passwordStrength'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* Copyright 2015, 2016 Parity Technologies (UK) Ltd. | ||
/* This file is part of Parity. | ||
/* | ||
/* Parity is free software: you can redistribute it and/or modify | ||
/* it under the terms of the GNU General Public License as published by | ||
/* the Free Software Foundation, either version 3 of the License, or | ||
/* (at your option) any later version. | ||
/* | ||
/* Parity is distributed in the hope that it will be useful, | ||
/* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
/* GNU General Public License for more details. | ||
/* | ||
/* You should have received a copy of the GNU General Public License | ||
/* along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
.strength { | ||
margin-top: 1.25em; | ||
} | ||
|
||
.feedback { | ||
font-size: 0.75em; | ||
} | ||
|
||
.label { | ||
user-select: none; | ||
line-height: 18px; | ||
font-size: 12px; | ||
color: rgba(255, 255, 255, 0.498039); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
// Copyright 2015, 2016 Parity Technologies (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
import React, { Component, PropTypes } from 'react'; | ||
import { debounce } from 'lodash'; | ||
import { LinearProgress } from 'material-ui'; | ||
import { FormattedMessage } from 'react-intl'; | ||
import zxcvbn from 'zxcvbn'; | ||
|
||
import styles from './passwordStrength.css'; | ||
|
||
const BAR_STYLE = { | ||
borderRadius: 1, | ||
height: 7, | ||
marginTop: '0.5em' | ||
}; | ||
|
||
export default class PasswordStrength extends Component { | ||
static propTypes = { | ||
input: PropTypes.string.isRequired | ||
}; | ||
|
||
state = { | ||
strength: null | ||
}; | ||
|
||
constructor (props) { | ||
super(props); | ||
|
||
this.updateStrength = debounce(this._updateStrength, 50, { leading: true }); | ||
} | ||
|
||
componentWillMount () { | ||
this.updateStrength(this.props.input); | ||
} | ||
|
||
componentWillReceiveProps (nextProps) { | ||
if (nextProps.input !== this.props.input) { | ||
this.updateStrength(nextProps.input); | ||
} | ||
} | ||
|
||
_updateStrength (input = '') { | ||
const strength = zxcvbn(input); | ||
this.setState({ strength }); | ||
} | ||
|
||
render () { | ||
const { strength } = this.state; | ||
|
||
if (!strength) { | ||
return null; | ||
} | ||
|
||
const { score, feedback } = strength; | ||
|
||
// Score is between 0 and 4 | ||
const value = score * 100 / 5 + 20; | ||
const color = this.getStrengthBarColor(score); | ||
|
||
return ( | ||
<div className={ styles.strength }> | ||
<label className={ styles.label }> | ||
<FormattedMessage | ||
id='ui.passwordStrength.label' | ||
defaultMessage='password strength' | ||
/> | ||
</label> | ||
<LinearProgress | ||
color={ color } | ||
mode='determinate' | ||
style={ BAR_STYLE } | ||
value={ value } | ||
/> | ||
<div className={ styles.feedback }> | ||
{ this.renderFeedback(feedback) } | ||
</div> | ||
</div> | ||
); | ||
} | ||
|
||
// Note that the suggestions are in english, thus it wouldn't | ||
// make sense to add translations to surrounding words | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We cannot be 99.9% and once in we shouldn't need to come back. What are the alternatives? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To clarify the above - at the very least all our text should be i18n. (3rd party could be non - for now). So the below should either just display the library hint or split it such that our part is translatable and their part a variable input. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (This has been taken care of) |
||
renderFeedback (feedback = {}) { | ||
const { suggestions = [] } = feedback; | ||
|
||
return ( | ||
<div> | ||
<p> | ||
{ suggestions.join(' ') } | ||
</p> | ||
</div> | ||
); | ||
} | ||
|
||
getStrengthBarColor (score) { | ||
switch (score) { | ||
case 4: | ||
case 3: | ||
return 'lightgreen'; | ||
|
||
case 2: | ||
return 'yellow'; | ||
|
||
case 1: | ||
return 'orange'; | ||
|
||
default: | ||
return 'red'; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are in this file and it is new, alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it is, except for React which is the main dependency of this module, I don't think it's necessarily bad to have it on top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have expected at least the react-releated stuff to follow react, hence making exceptions jumbles it up and seems random. i.e. we typically do (not the case here)
(grouped above, easy to see relations)
Here React is the exception, the rest sorted so it is a mix-match. Small thing (and driving me crazy), but like with everything, allows us to not have to think "in this case we do it differently".
Not a crisis, still worth being consistent about.