This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Reload UI on network switch #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better than what we have. We however need to actually just reload the affected accounts - refresh accounts, balances, contracts, etc. (Clear cache, start over.) For network itself we really don't need to reload the UI. |
jacogr
added
A6-mustntgrumble 💦
gavofyork
reviewed
Mar 11, 2017
| @@ -18,6 +18,10 @@ import BalancesProvider from './balances'; | |||
| import { showSnackbar } from './snackbarActions'; | |||
| import { DEFAULT_NETCHAIN } from './statusReducer'; | |||
|
|
|||
| // Reload the page on network switch after | |||
| // 5 seconds | |||
| const RELOAD_TIMEOUT = 5000; | |||
There was a problem hiding this comment.
@ngotchac any reason this is not instant? just looks to me like 5 of incorrectness.
gavofyork
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
|
Tested. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4814