This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Don't remove confirmed requests to early. #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
arkpar
approved these changes
Mar 16, 2017
ngotchac
approved these changes
Mar 16, 2017
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of two independent clients waiting for the same request to finish using
check_requestonly one could get a proper response.This PR will remove completed entries after 60s of inactivity.
To prevent an attack where sender tries to keep all entries active there is an upper limit equal to signing queue upper limit.