Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update expanse json with fork at block 600000 #5351

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Update expanse json with fork at block 600000 #5351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2262b63
Update expanse json with fork at block 600000
chrisfranko Mar 30, 2017
666996d
update exp chainID to 2
chrisfranko Mar 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ethcore/res/ethereum/expanse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
"difficultyHardforkTransition": "0x59d9",
"difficultyHardforkBoundDivisor": "0x0200",
"bombDefuseTransition": "0x30d40",
"eip150Transition": "0x7fffffffffffffff",
"eip155Transition": "0x7fffffffffffffff",
"eip160Transition": "0x7fffffffffffffff",
"eip161abcTransition": "0x7fffffffffffffff",
"eip161dTransition": "0x7fffffffffffffff"
"eip150Transition": "0x927C0",
"eip155Transition": "0x927C0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With EIP155 enabled, you may want to specify a "chainID" in params. Otherwise, transactions from the Ethereum mainnet will still be replayable onto expanse and vice-versa as they both specify network ID 1, defeating the point a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, chainID is used only for transaction signing and defaults to the value of networkID if not specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I get what you are saying, however Expanse uses a completely different network identifier so nodes dont even have the ability to talk to each other and fail at the handshake. I suppose people could copy over a raw tx and try to replay those txs on EXP but its highly unlikely any EXP addresses are also used for ETH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man I just went full potato, sorry, doing 100 things at once today. Ill choose a chainID and submit it in a few, sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphmeier updated to chainID 2, since etc chose 61.

"eip160Transition": "0x927C0",
"eip161abcTransition": "0x927C0",
"eip161dTransition": "0x927C0"
}
}
},
Expand All @@ -28,6 +28,7 @@
"maximumExtraDataSize": "0x20",
"minGasLimit": "0x1388",
"networkID": "0x1",
"chainID": "0x2",
"subprotocolName": "exp",
"eip98Transition": "0x7fffffffffffff"
},
Expand Down