Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Adding CLI options: port shift and unsafe expose. #5677

Merged
merged 5 commits into from
May 23, 2017
Merged

Adding CLI options: port shift and unsafe expose. #5677

merged 5 commits into from
May 23, 2017

Conversation

tomusdrw
Copy link
Collaborator

  1. Allows to run two instances easily.
  2. Allows to expose a node easily (for instance when running in Docker container or just playing around).
  3. --*-interface all now implies --*-hosts all unless configured differently.

Most probably will need some merging with #5580

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels May 22, 2017
@tomusdrw tomusdrw requested review from gavofyork and rphmeier May 22, 2017 13:52
Includes network port and all servers (RPC, WebSockets, UI, IPFS, SecretStore).
(default: {flag_ports_shift})
--unsafe-expose All servers will listen on external interfaces and will
be remotely accessible. It's equivallent with setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: equivalent

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@arkpar arkpar merged commit f47cbe0 into master May 23, 2017
@arkpar arkpar deleted the servers branch May 23, 2017 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants