Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Require phrase confirmation. #5731

Merged
merged 6 commits into from
Jun 9, 2017
Merged

Require phrase confirmation. #5731

merged 6 commits into from
Jun 9, 2017

Conversation

tomusdrw
Copy link
Collaborator

I've decided to allow users to go back on the confirmation page - I think it would be very frustrating if you went through the process and couldn't finish it cause you didn't backup the phrase (especially on test networks).

On non-test networks pasting the whole phrase is also blocked (you can paste up to 8 characters - so pasting word by word should work fine).

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels May 31, 2017
@tomusdrw tomusdrw requested review from jacogr and ngotchac May 31, 2017 13:20
@tomusdrw tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. B0-patch and removed A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Jun 1, 2017
@tomusdrw tomusdrw removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jun 1, 2017
@CraigglesO
Copy link
Contributor

I don't like that people can't paste in the full thing. Forcing them to copy paste in the first place already gets the user thinking about the importance.
I also think they should just paste in the security phrase.
I mean realistically, if they make a mistake and don't have the security phrase, just make another. it's incredibly easy.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Jun 2, 2017
@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Jun 2, 2017

Ok, so the flow is a bit changed now:

  1. When the phrase is displayed user needs to type in "I have written down the phrase" to go to the next step.
  2. On the next step she needs to type the fully recovery phrase (and there is no back button).

Pasting is disabled on non-test networks. If we allow pasting there people will just store the phrase in the clipboard and won't back it up.
IMHO there has been too many people that didn't back up the phrase earlier (even though we outline the importance of that) and lost their ETH because of that. We really should do whatever is (reasonably) possible to force them to back it up.

Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm code-wise.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 6, 2017
@gavofyork gavofyork merged commit 5c3ea4e into master Jun 9, 2017
@gavofyork gavofyork deleted the confirm-backup branch June 9, 2017 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants