Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

jsonrpc uses client and sync interfaces #641

Merged
merged 1 commit into from
Mar 10, 2016
Merged

jsonrpc uses client and sync interfaces #641

merged 1 commit into from
Mar 10, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 9, 2016

it's a preparation for jsonrpc tests

changes:

  • sealing_block and submit_seal are now a part of BlockChainClient trait
  • new trait SyncStatusProvider (implemented by EthSync)
  • rpc server uses BlockChainClient and SyncStatus Provider instead of Client and EthSync.

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Mar 9, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 9, 2016
@gavofyork gavofyork added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Mar 9, 2016
@tomusdrw tomusdrw mentioned this pull request Mar 10, 2016
Closed
gavofyork added a commit that referenced this pull request Mar 10, 2016
@gavofyork
Merge pull request #641 from ethcore/jsonrpc_interfaces
8dd41bf 
jsonrpc uses client and sync interfaces
@gavofyork gavofyork merged commit 8dd41bf into master Mar 10, 2016
@gavofyork gavofyork deleted the jsonrpc_interfaces branch March 10, 2016 14:44
@NikVolf NikVolf mentioned this pull request Mar 10, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @gavofyork @NikVolf