This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix #6209 - introduce standalone dir crate #6952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done so far: * created the dir crate in util * moved code from `ethstore/src/dir/paths.rs` to dir crate * rename `dir` module in ethstore to `accounts_dir` to distinguish it from the dir crate Is there a need to mutualize some code in the newly created `util/dir/src/lib.rs` ? If so, I would need some guidance as of which functions are to be mutualized.
|
It looks like @nicolasochem signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
5chdn
added
A0-pleasereview 🤓
tomusdrw
reviewed
Nov 30, 2017
| @@ -21,7 +21,8 @@ use std::collections::HashSet; | |||
|
|
|||
| use dapps; | |||
| use dir::default_data_path; | |||
| use helpers::{parity_ipc_path, replace_home}; | |||
| use helpers::parity_ipc_path; | |||
There was a problem hiding this comment.
Could you keep the imports sorted?
| r.replace("/", &::std::path::MAIN_SEPARATOR.to_string()) | ||
| } | ||
|
|
||
| pub fn replace_home_and_local(base: &str, local: &str, arg: &str) -> String { |
| @@ -14,7 +14,12 @@ | |||
| // You should have received a copy of the GNU General Public License | |||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| use std::fs; | |||
| extern crate app_dirs; | |||
There was a problem hiding this comment.
Please add #![warn(missing_docs)]
| base | ||
| } | ||
|
|
||
| #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
Might be better to group the functions into a platform module:
#[cfg(target_os = "macos")]
mod platform {
fn parity_base() {}
fn geth_base() {}
}
tomusdrw
added
A5-grumble 🔥
tomusdrw
added
the
A3-stale 🍃
|
@nicolasochem any progress? |
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this pull request
Dec 26, 2017
* created the dir crate in util * moved code from ethstore/src/dir/paths.rs to dir crate * rename dir module in ethstore to accounts_dir to distinguish it from the dir crate * changes after @tomusdrw on openethereum#6952
|
replaced by #7383 |
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this pull request
Dec 26, 2017
* created the dir crate in util * moved code from ethstore/src/dir/paths.rs to dir crate * rename dir module in ethstore to accounts_dir to distinguish it from the dir crate * changes after @tomusdrw on openethereum#6952
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done so far:
ethstore/src/dir/paths.rsto dir cratedirmodule in ethstore toaccounts_dirto distinguish itfrom the dir crate
Is there a need to mutualize some code in the newly created
util/dir/src/lib.rs? If so, I would need some guidance as of whichfunctions are to be mutualized.