This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix tracing failed calls. #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
debris
approved these changes
Jan 2, 2018
debris
reviewed
Jan 2, 2018
| @@ -21,3 +21,5 @@ rustc-hex = "1.0" | |||
|
|
|||
| [features] | |||
| jit = ["evmjit"] | |||
| evm-debug = [] | |||
| evm-debug-tests = ["evm-debug"] | |||
There was a problem hiding this comment.
why introducing a new feature? is it used anywhere else? I can't see
There was a problem hiding this comment.
It is part of evm crate now and used to be part of ethcore - the feature was not correctly migrated when those two were split. It prints out VMtracing when running interpreter tests and is quite helpful.
debris
added
A8-looksgood 🦄
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7187